History

io_uring: fix recvmsg memory leak with buffer selection

io_recvmsg() doesn't free memory allocated for struct io_buffer. This can causes a leak when used with automatic buffer selection.

Pavel Begunkov committed 6 years ago

Commit 681fda81 parent 16d59801 file · +8 −2Browse files

Unified · Split

fs/io_uring.c+8−2
@@ -3845,10 +3845,16 @@ static int io_recvmsg(struct io_kiocb *req, bool force_nonblock) · 3844 unmodified lines
38453845
38463846 ret = __sys_recvmsg_sock(sock, &kmsg->msg, req->sr_msg.msg,
38473847 kmsg->uaddr, flags);
3848− if (force_nonblock && ret == -EAGAIN)
3849− return io_setup_async_msg(req, kmsg);
3848+ if (force_nonblock && ret == -EAGAIN) {
3849+ ret = io_setup_async_msg(req, kmsg);
3850+ if (ret != -EAGAIN)
3851+ kfree(kbuf);
3852+ return ret;
3853+ }
38503854 if (ret == -ERESTARTSYS)
38513855 ret = -EINTR;
3856+ if (kbuf)
3857+ kfree(kbuf);
38523858 }
38533859
38543860 if (kmsg && kmsg->iov != kmsg->fast_iov)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t