History

f2fs: Fix mount failure due to SPO after a successful online resize FS

Even though online resize is successfully done, a SPO immediately after resize, still causes below error in the next mount. [ 11.294650] F2FS-fs (sda8): Wrong user_block_count: 2233856 [ 11.300272] F2FS-fs (sda8): Failed to get valid F2FS checkpoint This is because after FS metadata is updated in update_fs_metadata() if the SBI_IS_DIRTY is not dirty, then CP will not be done to reflect the new user_block_count.

Sahitya Tummala committed 6 years ago

Commit 68275681 parent a9991501 file · +6 −0Browse files

Unified · Split

fs/f2fs/gc.c+6−0
@@ -1578,11 +1578,17 @@ int f2fs_resize_fs(struct f2fs_sb_info *sbi, __u64 block_count) · 1577 unmodified lines
15781578 goto out;
15791579 }
15801580
1581+ mutex_lock(&sbi->cp_mutex);
15811582 update_fs_metadata(sbi, -secs);
15821583 clear_sbi_flag(sbi, SBI_IS_RESIZEFS);
1584+ set_sbi_flag(sbi, SBI_IS_DIRTY);
1585+ mutex_unlock(&sbi->cp_mutex);
1586+
15831587 err = f2fs_sync_fs(sbi->sb, 1);
15841588 if (err) {
1589+ mutex_lock(&sbi->cp_mutex);
15851590 update_fs_metadata(sbi, secs);
1591+ mutex_unlock(&sbi->cp_mutex);
15861592 update_sb_metadata(sbi, secs);
15871593 f2fs_commit_super(sbi, false);
15881594 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t