The "param.count" value is a u64 thatcomes from the user. The code later in the function assumes that param.count is at least one and if it's not then it leads to an Oops when we dereference the ZERO_SIZE_PTR. Also the addition can have an integer overflow which would lead us to allocate a smaller "pages" array than required. I can't immediately tell what the possible run times implications are, but it's safest to prevent the overflow.
Unified · Split
| @@ -215,6 +215,9 @@ static long ioctl_memcpy(struct fsl_hv_ioctl_memcpy __user *p) · 214 unmodified lines | |||
| 215 | * hypervisor. | 215 | * hypervisor. |
| 216 | */ | 216 | */ |
| 217 | lb_offset = param.local_vaddr & (PAGE_SIZE - 1); | 217 | lb_offset = param.local_vaddr & (PAGE_SIZE - 1); |
| 218 | if (param.count == 0 || | ||
| 219 | param.count > U64_MAX - lb_offset - PAGE_SIZE + 1) | ||
| 220 | return -EINVAL; | ||
| 218 | num_pages = (param.count + lb_offset + PAGE_SIZE - 1) >> PAGE_SHIFT; | 221 | num_pages = (param.count + lb_offset + PAGE_SIZE - 1) >> PAGE_SHIFT; |
| 219 | 222 | ||
| 220 | /* Allocate the buffers we need */ | 223 | /* Allocate the buffers we need */ |