History

genirq: Don't return ENOSYS in irq_chip_retrigger_hierarchy

irq_chip_retrigger_hierarchy() returns -ENOSYS if it was not able to find at least one .irq_retrigger() callback implemented in the IRQ domain hierarchy. That's wrong, because check_irq_resend() expects a 0 return value from the callback in case that the hardware assisted resend was not possible. If the return value is non zero the core code assumes hardware resend success and the software resend is not invoked. This results in lost interrupts on platforms where none of the parent irq chips in the hierarchy implements the retrigger callback. This is observable on TI OMAP, where the hierarchy is: ARM GIC <- OMAP wakeupgen <- TI Crossbar Return 0 instead so the software resend mechanism gets invoked. [ tglx: Massaged changelog ]

Grygorii Strashko committed 11 years ago

Commit 6d4affe1 parent a36304b1 file · +1 −1Browse files

Unified · Split

kernel/irq/chip.c+1−1
@@ -997,7 +997,7 @@ int irq_chip_retrigger_hierarchy(struct irq_data *data) · 996 unmodified lines
997997 if (data->chip && data->chip->irq_retrigger)
998998 return data->chip->irq_retrigger(data);
999999
1000− return -ENOSYS;
1000+ return 0;
10011001 }
10021002
10031003 /**

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t