History

HID: cp2112: fix to force single data-report reply

Current implementation of cp2112_raw_event() only accepts one data report at a time. If last received data report is not fully handled yet, a new incoming data report will overwrite it. In such case we don't guaranteed to propagate the correct incoming data. The trivial fix implemented here forces a single report at a time by requesting in cp2112_read() no more than 61 byte of data, which is the payload size of a single data report.

Antonio Borneo committed 11 years ago

Commit 6debce61 parent 96339201 file · +2 −0Browse files

Unified · Split

drivers/hid/hid-cp2112.c+2−0
@@ -356,6 +356,8 @@ static int cp2112_read(struct cp2112_device *dev, u8 *data, size_t size) · 355 unmodified lines
356 struct cp2112_force_read_report report;356 struct cp2112_force_read_report report;
357 int ret;357 int ret;
358 358
359 if (size > sizeof(dev->read_data))
360 size = sizeof(dev->read_data);
359 report.report = CP2112_DATA_READ_FORCE_SEND;361 report.report = CP2112_DATA_READ_FORCE_SEND;
360 report.length = cpu_to_be16(size);362 report.length = cpu_to_be16(size);
361 363

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t