If firmware doesn't implement any of the ARS commands, take that to mean that ARS is unsupported, and continue to initialize regions without bad block lists. We cannot make the assumption that ARS commands will be unconditionally supported on all NVDIMMs.
Unified · Split
| @@ -1590,14 +1590,21 @@ static int acpi_nfit_find_poison(struct acpi_nfit_desc *acpi_desc, · 1589 unmodified lines | |||
| 1590 | start = ndr_desc->res->start; | 1590 | start = ndr_desc->res->start; |
| 1591 | len = ndr_desc->res->end - ndr_desc->res->start + 1; | 1591 | len = ndr_desc->res->end - ndr_desc->res->start + 1; |
| 1592 | 1592 | ||
| 1593 | /* | ||
| 1594 | * If ARS is unimplemented, unsupported, or if the 'Persistent Memory | ||
| 1595 | * Scrub' flag in extended status is not set, skip this but continue | ||
| 1596 | * initialization | ||
| 1597 | */ | ||
| 1593 | rc = ars_get_cap(nd_desc, ars_cap, start, len); | 1598 | rc = ars_get_cap(nd_desc, ars_cap, start, len); |
| 1599 | if (rc == -ENOTTY) { | ||
| 1600 | dev_dbg(acpi_desc->dev, | ||
| 1601 | "Address Range Scrub is not implemented, won't create an error list\n"); | ||
| 1602 | rc = 0; | ||
| 1603 | goto out; | ||
| 1604 | } | ||
| 1594 | if (rc) | 1605 | if (rc) |
| 1595 | goto out; | 1606 | goto out; |
| 1596 | 1607 | ||
| 1597 | /* | ||
| 1598 | * If ARS is unsupported, or if the 'Persistent Memory Scrub' flag in | ||
| 1599 | * extended status is not set, skip this but continue initialization | ||
| 1600 | */ | ||
| 1601 | if ((ars_cap->status & 0xffff) || | 1608 | if ((ars_cap->status & 0xffff) || |
| 1602 | !(ars_cap->status >> 16 & ND_ARS_PERSISTENT)) { | 1609 | !(ars_cap->status >> 16 & ND_ARS_PERSISTENT)) { |
| 1603 | dev_warn(acpi_desc->dev, | 1610 | dev_warn(acpi_desc->dev, |