The entire way how cros debugfs attibutes are created is broken. cros_ec_debugfs should be its own driver and its attributes should be associated with a debugfs driver not the mfd driver.
Showing the changes to include/linux (1 of 5 files). Show all
Unified · Split
| @@ -328,10 +328,4 @@ u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev); · 327 unmodified lines | |||
| 328 | /* sysfs stuff */ | 328 | /* sysfs stuff */ |
| 329 | extern struct attribute_group cros_ec_attr_group; | 329 | extern struct attribute_group cros_ec_attr_group; |
| 330 | 330 | ||
| 331 | /* debugfs stuff */ | ||
| 332 | int cros_ec_debugfs_init(struct cros_ec_dev *ec); | ||
| 333 | void cros_ec_debugfs_remove(struct cros_ec_dev *ec); | ||
| 334 | void cros_ec_debugfs_suspend(struct cros_ec_dev *ec); | ||
| 335 | void cros_ec_debugfs_resume(struct cros_ec_dev *ec); | ||
| 336 | |||
| 337 | #endif /* __LINUX_MFD_CROS_EC_H */ | 331 | #endif /* __LINUX_MFD_CROS_EC_H */ |