History

media: vimc: fill in bus_info in media_device_info

It is good practice to fill in bus_info. Also just use 'platform:vimc' when filling in the bus_info in querycap: the bus_info has nothing to do with the video device name.

Hans Verkuil committed 7 years ago

Commit 6fd369d1 parent db89a472 files · +3 −3Browse files

Unified · Split

2 files
  1. drivers/media/platform/vimc/vimc-capture.c +1 −3
  2. drivers/media/platform/vimc/vimc-core.c +2 −0
drivers/media/platform/vimc/vimc-capture.c+1−3
@@ -70,12 +70,10 @@ struct vimc_cap_buffer { · 69 unmodified lines
7070 static int vimc_cap_querycap(struct file *file, void *priv,
7171 struct v4l2_capability *cap)
7272 {
73− struct vimc_cap_device *vcap = video_drvdata(file);
74−
7573 strscpy(cap->driver, VIMC_PDEV_NAME, sizeof(cap->driver));
7674 strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card));
7775 snprintf(cap->bus_info, sizeof(cap->bus_info),
78− "platform:%s", vcap->vdev.v4l2_dev->name);
76+ "platform:%s", VIMC_PDEV_NAME);
7977
8078 return 0;
8179 }
drivers/media/platform/vimc/vimc-core.c+2−0
@@ -318,6 +318,8 @@ static int vimc_probe(struct platform_device *pdev) · 317 unmodified lines
318318 /* Initialize media device */
319319 strscpy(vimc->mdev.model, VIMC_MDEV_MODEL_NAME,
320320 sizeof(vimc->mdev.model));
321+ snprintf(vimc->mdev.bus_info, sizeof(vimc->mdev.bus_info),
322+ "platform:%s", VIMC_PDEV_NAME);
321323 vimc->mdev.dev = &pdev->dev;
322324 media_device_init(&vimc->mdev);
323325