Since this is handling user provided bpp and depth, we need to sanity check and propagate the EINVAL back rather than assume what the insane client intended and fill the logs with DRM_ERROR. v2: Check both bpp and depth match the builtin pixel format, and introduce a canonical DRM_FORMAT_INVALID to reserve 0 against any future fourcc. v3: Mark up DRM_FORMAT_C8 as being {bpp:8, depth:8}
Unified · Split
| @@ -45,32 +45,49 @@ static char printable_char(int c) · 44 unmodified lines | ||
| 45 | 45 | */ |
| 46 | 46 | uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth) |
| 47 | 47 | { |
| 48 | − uint32_t fmt; | |
| 48 | + uint32_t fmt = DRM_FORMAT_INVALID; | |
| 49 | 49 | |
| 50 | 50 | switch (bpp) { |
| 51 | 51 | case 8: |
| 52 | − fmt = DRM_FORMAT_C8; | |
| 52 | + if (depth == 8) | |
| 53 | + fmt = DRM_FORMAT_C8; | |
| 53 | 54 | break; |
| 55 | + | |
| 54 | 56 | case 16: |
| 55 | − if (depth == 15) | |
| 57 | + switch (depth) { | |
| 58 | + case 15: | |
| 56 | 59 | fmt = DRM_FORMAT_XRGB1555; |
| 57 | − else | |
| 60 | + break; | |
| 61 | + case 16: | |
| 58 | 62 | fmt = DRM_FORMAT_RGB565; |
| 63 | + break; | |
| 64 | + default: | |
| 65 | + break; | |
| 66 | + } | |
| 59 | 67 | break; |
| 68 | + | |
| 60 | 69 | case 24: |
| 61 | − fmt = DRM_FORMAT_RGB888; | |
| 70 | + if (depth == 24) | |
| 71 | + fmt = DRM_FORMAT_RGB888; | |
| 62 | 72 | break; |
| 73 | + | |
| 63 | 74 | case 32: |
| 64 | − if (depth == 24) | |
| 75 | + switch (depth) { | |
| 76 | + case 24: | |
| 65 | 77 | fmt = DRM_FORMAT_XRGB8888; |
| 66 | − else if (depth == 30) | |
| 78 | + break; | |
| 79 | + case 30: | |
| 67 | 80 | fmt = DRM_FORMAT_XRGB2101010; |
| 68 | − else | |
| 81 | + break; | |
| 82 | + case 32: | |
| 69 | 83 | fmt = DRM_FORMAT_ARGB8888; |
| 84 | + break; | |
| 85 | + default: | |
| 86 | + break; | |
| 87 | + } | |
| 70 | 88 | break; |
| 89 | + | |
| 71 | 90 | default: |
| 72 | − DRM_ERROR("bad bpp, assuming x8r8g8b8 pixel format\n"); | |
| 73 | − fmt = DRM_FORMAT_XRGB8888; | |
| 74 | 91 | break; |
| 75 | 92 | } |
| 76 | 93 | |
| @@ -112,12 +112,17 @@ int drm_mode_addfb(struct drm_device *dev, struct drm_mode_fb_cmd *or, · 111 unmodified lines | ||
| 112 | 112 | struct drm_mode_fb_cmd2 r = {}; |
| 113 | 113 | int ret; |
| 114 | 114 | |
| 115 | + r.pixel_format = drm_mode_legacy_fb_format(or->bpp, or->depth); | |
| 116 | + if (r.pixel_format == DRM_FORMAT_INVALID) { | |
| 117 | + DRM_DEBUG("bad {bpp:%d, depth:%d}\n", or->bpp, or->depth); | |
| 118 | + return -EINVAL; | |
| 119 | + } | |
| 120 | + | |
| 115 | 121 | /* convert to new format and call new ioctl */ |
| 116 | 122 | r.fb_id = or->fb_id; |
| 117 | 123 | r.width = or->width; |
| 118 | 124 | r.height = or->height; |
| 119 | 125 | r.pitches[0] = or->pitch; |
| 120 | − r.pixel_format = drm_mode_legacy_fb_format(or->bpp, or->depth); | |
| 121 | 126 | r.handles[0] = or->handle; |
| 122 | 127 | |
| 123 | 128 | if (dev->mode_config.quirk_addfb_prefer_xbgr_30bpp && |
| @@ -71,6 +71,9 @@ extern "C" { · 70 unmodified lines | ||
| 71 | 71 | |
| 72 | 72 | #define DRM_FORMAT_BIG_ENDIAN (1<<31) /* format is big endian instead of little endian */ |
| 73 | 73 | |
| 74 | +/* Reserve 0 for the invalid format specifier */ | |
| 75 | +#define DRM_FORMAT_INVALID 0 | |
| 76 | + | |
| 74 | 77 | /* color index */ |
| 75 | 78 | #define DRM_FORMAT_C8 fourcc_code('C', '8', ' ', ' ') /* [7:0] C */ |
| 76 | 79 | |