History

drm: deprecate DRM_FORMAT_MOD_NONE

DRM_FORMAT_MOD_NONE is in the list of vendors, which is pretty confusing. We already have DRM_FORMAT_MOD_VENDOR_NONE. Move it down in the list of format modifiers. DRM_FORMAT_MOD_NONE is an alias for DRM_FORMAT_MOD_LINEAR, however the name is confusing: NONE doesn't mean that the modifier is implicit, instead it means that the layout is linear. Deprecate it.

Simon Ser committed 6 years ago

Commit 70bb9191 parent e34b8fe1 file · +10 −1Browse files

Showing the changes to include/uapi (1 of 1 file). Show all

Unified · Split

include/uapi/drm/drm_fourcc.h+10−1
@@ -350,7 +350,6 @@ extern "C" { · 349 unmodified lines
350350 */
351351
352352 /* Vendor Ids: */
353−#define DRM_FORMAT_MOD_NONE 0
354353 #define DRM_FORMAT_MOD_VENDOR_NONE 0
355354 #define DRM_FORMAT_MOD_VENDOR_INTEL 0x01
356355 #define DRM_FORMAT_MOD_VENDOR_AMD 0x02
@@ -422,6 +421,16 @@ extern "C" { · 65 unmodified lines
422421 */
423422 #define DRM_FORMAT_MOD_LINEAR fourcc_mod_code(NONE, 0)
424423
424+/*
425+ * Deprecated: use DRM_FORMAT_MOD_LINEAR instead
426+ *
427+ * The "none" format modifier doesn't actually mean that the modifier is
428+ * implicit, instead it means that the layout is linear. Whether modifiers are
429+ * used is out-of-band information carried in an API-specific way (e.g. in a
430+ * flag for drm_mode_fb_cmd2).
431+ */
432+#define DRM_FORMAT_MOD_NONE 0
433+
425434 /* Intel framebuffer modifiers */
426435
427436 /*