History

drm/xe/uapi: Align on a common way to return arrays (gt)

The uAPI provides queries which return arrays of elements. As of now the format used in the struct is different depending on which element is queried. However, aligning on the new common pattern: struct drm_xe_query_Xs { __u32 num_Xs; struct drm_xe_X Xs[]; ... } ... would mean bringing back the name "gts" which is avoided per commit fca54ba12470 ("drm/xe/uapi: Rename gts to gt_list") so make an exception for gt and leave gt_list. Also, this change removes "query" in the name of struct drm_xe_query_gt as it is not returned from the query IOCTL. There is no functional change. v2: Leave gt_list (Matt Roper)

Francois Dugast committed 2 years ago

Commit 71c625a1 parent 4bc9dd92 files · +4 −4Browse files

Showing the changes to include/uapi (1 of 2 files). Show all

Unified · Split

include/uapi/drm/xe_drm.h+3−3
@@ -357,14 +357,14 @@ struct drm_xe_query_config { · 356 unmodified lines
357};357};
358 358
359/**359/**
360 * struct drm_xe_query_gt - describe an individual GT.360 * struct drm_xe_gt - describe an individual GT.
361 *361 *
362 * To be used with drm_xe_query_gt_list, which will return a list with all the362 * To be used with drm_xe_query_gt_list, which will return a list with all the
363 * existing GT individual descriptions.363 * existing GT individual descriptions.
364 * Graphics Technology (GT) is a subset of a GPU/tile that is responsible for364 * Graphics Technology (GT) is a subset of a GPU/tile that is responsible for
365 * implementing graphics and/or media operations.365 * implementing graphics and/or media operations.
366 */366 */
367struct drm_xe_query_gt {367struct drm_xe_gt {
368#define DRM_XE_QUERY_GT_TYPE_MAIN 0368#define DRM_XE_QUERY_GT_TYPE_MAIN 0
369#define DRM_XE_QUERY_GT_TYPE_MEDIA 1369#define DRM_XE_QUERY_GT_TYPE_MEDIA 1
370 /** @type: GT type: Main or Media */370 /** @type: GT type: Main or Media */
@@ -404,7 +404,7 @@ struct drm_xe_query_gt_list { · 33 unmodified lines
404 /** @pad: MBZ */404 /** @pad: MBZ */
405 __u32 pad;405 __u32 pad;
406 /** @gt_list: The GT list returned for this device */406 /** @gt_list: The GT list returned for this device */
407 struct drm_xe_query_gt gt_list[];407 struct drm_xe_gt gt_list[];
408};408};
409 409
410/**410/**

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t