The function tracing_alloc_snapshot() is only used between trace.c and trace_snapshot.c. When snapshot isn't configured, it's not used at all. The stub function was defined as a global with no users and no prototype causing build issues. Remove the function when snapshot isn't configured as nothing is calling it. Also remove the EXPORT_SYMBOL_GPL() that was associated with it as it's not used outside of the tracing subsystem which also includes any modules.
Showing the changes to kernel (1 of 1 file). Show all
Unified · Split
| @@ -810,19 +810,12 @@ int tracing_alloc_snapshot(void) · 809 unmodified lines | |||
| 810 | 810 | ||
| 811 | return ret; | 811 | return ret; |
| 812 | } | 812 | } |
| 813 | EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); | ||
| 814 | #else | 813 | #else |
| 815 | void tracing_snapshot(void) | 814 | void tracing_snapshot(void) |
| 816 | { | 815 | { |
| 817 | WARN_ONCE(1, "Snapshot feature not enabled, but internal snapshot used"); | 816 | WARN_ONCE(1, "Snapshot feature not enabled, but internal snapshot used"); |
| 818 | } | 817 | } |
| 819 | EXPORT_SYMBOL_GPL(tracing_snapshot); | 818 | EXPORT_SYMBOL_GPL(tracing_snapshot); |
| 820 | int tracing_alloc_snapshot(void) | ||
| 821 | { | ||
| 822 | WARN_ONCE(1, "Snapshot feature not enabled, but snapshot allocation used"); | ||
| 823 | return -ENODEV; | ||
| 824 | } | ||
| 825 | EXPORT_SYMBOL_GPL(tracing_alloc_snapshot); | ||
| 826 | void tracing_snapshot_alloc(void) | 819 | void tracing_snapshot_alloc(void) |
| 827 | { | 820 | { |
| 828 | /* Give warning */ | 821 | /* Give warning */ |