When changing from one data interface setting to another, one has to ensure a specific sequence which is described in the ONFI spec. One of these constraints is that the CE line has go high after a reset before a command can be sent with the new data interface setting, which is not guaranteed by the current implementation. Rework the nand_reset() function and all the call sites to make sure the CE line is asserted and released when required. Also make sure to actually apply the new data interface setting on the first die.
Showing the changes to include/linux (1 of 2 files). Show all
Unified · Split
| @@ -1184,7 +1184,7 @@ int nand_read_oob_syndrome(struct mtd_info *mtd, struct nand_chip *chip, · 1183 unmodified lines | ||
| 1184 | 1184 | int page); |
| 1185 | 1185 | |
| 1186 | 1186 | /* Reset and initialize a NAND device */ |
| 1187 | −int nand_reset(struct nand_chip *chip); | |
| 1187 | +int nand_reset(struct nand_chip *chip, int chipnr); | |
| 1188 | 1188 | |
| 1189 | 1189 | /* Free resources held by the NAND device */ |
| 1190 | 1190 | void nand_cleanup(struct nand_chip *chip); |