History

ethtool: Name the 'no change' value for setting RSS hash key but not indir table

We usually allocate special values of u32 fields starting from the top down, so also change the value to 0xffffffff. As these operations haven't been included in a stable release yet, it's not too late to change.

Ben Hutchings committed 12 years ago

Commit 7455fa21 parent fb95cd82 files · +14 −10Browse files

Showing the changes to include/uapi/linux (1 of 2 files). Show all

Unified · Split

include/uapi/linux/ethtool.h+7−5
@@ -850,7 +850,8 @@ struct ethtool_rxfh_indir { · 849 unmodified lines
850 * struct ethtool_rxfh - command to get/set RX flow hash indir or/and hash key.850 * struct ethtool_rxfh - command to get/set RX flow hash indir or/and hash key.
851 * @cmd: Specific command number - %ETHTOOL_GRSSH or %ETHTOOL_SRSSH851 * @cmd: Specific command number - %ETHTOOL_GRSSH or %ETHTOOL_SRSSH
852 * @rss_context: RSS context identifier.852 * @rss_context: RSS context identifier.
853 * @indir_size: On entry, the array size of the user buffer, which may be zero.853 * @indir_size: On entry, the array size of the user buffer, which may be zero,
854 * or (for %ETHTOOL_SRSSH), %ETH_RXFH_INDIR_NO_CHANGE.
854 * On return from %ETHTOOL_GRSSH, the array size of the hardware855 * On return from %ETHTOOL_GRSSH, the array size of the hardware
855 * indirection table.856 * indirection table.
856 * @key_size: On entry, the array size of the user buffer in bytes,857 * @key_size: On entry, the array size of the user buffer in bytes,
@@ -861,10 +862,10 @@ struct ethtool_rxfh_indir { · 4 unmodified lines
861 * of size @indir_size followed by hash key of size @key_size.862 * of size @indir_size followed by hash key of size @key_size.
862 *863 *
863 * For %ETHTOOL_GRSSH, a @indir_size and key_size of zero means that only the864 * For %ETHTOOL_GRSSH, a @indir_size and key_size of zero means that only the
864 * size should be returned. For %ETHTOOL_SRSSH, a @indir_size of 0xDEADBEEF865 * size should be returned. For %ETHTOOL_SRSSH, an @indir_size of
865 * means that indir table setting is not requested and a @indir_size of zero866 * %ETH_RXFH_INDIR_NO_CHANGE means that indir table setting is not requested
866 * means the indir table should be reset to default values. This last feature867 * and a @indir_size of zero means the indir table should be reset to default
867 * is not supported by the original implementations.868 * values.
868 */869 */
869struct ethtool_rxfh {870struct ethtool_rxfh {
870 __u32 cmd;871 __u32 cmd;
@@ -874,6 +875,7 @@ struct ethtool_rxfh { · 3 unmodified lines
874 __u32 rsvd[2];875 __u32 rsvd[2];
875 __u32 rss_config[0];876 __u32 rss_config[0];
876};877};
878#define ETH_RXFH_INDIR_NO_CHANGE 0xffffffff
877 879
878/**880/**
879 * struct ethtool_rx_ntuple_flow_spec - specification for RX flow filter881 * struct ethtool_rx_ntuple_flow_spec - specification for RX flow filter

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t