History

regulator: palmas: Remove *rdev[PALMAS_NUM_REGS] from struct palmas_pmic

This driver is using devm_regulator_register() so it is not necessary to save *rdev for clean up. Actually the pmic->rdev[id] is not used now.

Axel Lin committed 7 years ago

Commit 74b060d1 parent 88f268a2 files · +0 −13Browse files

Unified · Split

2 files
  1. drivers/regulator/palmas-regulator.c +0 −12
  2. include/linux/mfd/palmas.h +0 −1
drivers/regulator/palmas-regulator.c+0−12
@@ -991,9 +991,6 @@ static int palmas_ldo_registration(struct palmas_pmic *pmic, · 990 unmodified lines
991991 return PTR_ERR(rdev);
992992 }
993993
994− /* Save regulator for cleanup */
995− pmic->rdev[id] = rdev;
996−
997994 /* Initialise sleep/init values from platform data */
998995 if (pdata) {
999996 reg_init = pdata->reg_init[id];
@@ -1101,9 +1098,6 @@ static int tps65917_ldo_registration(struct palmas_pmic *pmic, · 101 unmodified lines
11011098 return PTR_ERR(rdev);
11021099 }
11031100
1104− /* Save regulator for cleanup */
1105− pmic->rdev[id] = rdev;
1106−
11071101 /* Initialise sleep/init values from platform data */
11081102 if (pdata) {
11091103 reg_init = pdata->reg_init[id];
@@ -1288,9 +1282,6 @@ static int palmas_smps_registration(struct palmas_pmic *pmic, · 178 unmodified lines
12881282 pdev_name);
12891283 return PTR_ERR(rdev);
12901284 }
1291−
1292− /* Save regulator for cleanup */
1293− pmic->rdev[id] = rdev;
12941285 }
12951286
12961287 return 0;
@@ -1395,9 +1386,6 @@ static int tps65917_smps_registration(struct palmas_pmic *pmic, · 98 unmodified lines
13951386 pdev_name);
13961387 return PTR_ERR(rdev);
13971388 }
1398−
1399− /* Save regulator for cleanup */
1400− pmic->rdev[id] = rdev;
14011389 }
14021390
14031391 return 0;
include/linux/mfd/palmas.h+0−1
@@ -553,7 +553,6 @@ struct palmas_pmic { · 552 unmodified lines
553553 struct palmas *palmas;
554554 struct device *dev;
555555 struct regulator_desc desc[PALMAS_NUM_REGS];
556− struct regulator_dev *rdev[PALMAS_NUM_REGS];
557556 struct mutex mutex;
558557
559558 int smps123;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t