The keyboard brightness control of Asus WMI keyboards is handled in kernel, which leads to the shortcut going from brightness 0, to 1, to 2, and 3. However, for HID keyboards it is exposed as a key and handled by the user's desktop environment. For the toggle button, this means that brightness control becomes on/off. In addition, in the absence of a DE, the keyboard brightness does not work. Therefore, expose an event handler for the keyboard brightness control which can then be used by hid-asus. Since this handler is called from an interrupt context, defer the actual work to a workqueue. In the process, introduce ASUS_EV_MAX_BRIGHTNESS to hold the constant for maximum brightness since it is shared between hid-asus/asus-wmi.
Showing the changes to include/linux/platform_data (1 of 2 files). Show all
Unified · Split
| @@ -178,6 +178,14 @@ struct asus_hid_listener { · 177 unmodified lines | ||
| 178 | 178 | void (*brightness_set)(struct asus_hid_listener *listener, int brightness); |
| 179 | 179 | }; |
| 180 | 180 | |
| 181 | +enum asus_hid_event { | |
| 182 | + ASUS_EV_BRTUP, | |
| 183 | + ASUS_EV_BRTDOWN, | |
| 184 | + ASUS_EV_BRTTOGGLE, | |
| 185 | +}; | |
| 186 | + | |
| 187 | +#define ASUS_EV_MAX_BRIGHTNESS 3 | |
| 188 | + | |
| 181 | 189 | #if IS_REACHABLE(CONFIG_ASUS_WMI) |
| 182 | 190 | void set_ally_mcu_hack(enum asus_ally_mcu_hack status); |
| 183 | 191 | void set_ally_mcu_powersave(bool enabled); |
| @@ -186,6 +194,7 @@ int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param, u32 *retval); · 2 unmodified lines | ||
| 186 | 194 | int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, u32 *retval); |
| 187 | 195 | int asus_hid_register_listener(struct asus_hid_listener *cdev); |
| 188 | 196 | void asus_hid_unregister_listener(struct asus_hid_listener *cdev); |
| 197 | +int asus_hid_event(enum asus_hid_event event); | |
| 189 | 198 | #else |
| 190 | 199 | static inline void set_ally_mcu_hack(enum asus_ally_mcu_hack status) |
| 191 | 200 | { |
| @@ -213,6 +222,10 @@ static inline int asus_hid_register_listener(struct asus_hid_listener *bdev) · 21 unmodified lines | ||
| 213 | 222 | static inline void asus_hid_unregister_listener(struct asus_hid_listener *bdev) |
| 214 | 223 | { |
| 215 | 224 | } |
| 225 | +static inline int asus_hid_event(enum asus_hid_event event) | |
| 226 | +{ | |
| 227 | + return -ENODEV; | |
| 228 | +} | |
| 216 | 229 | #endif |
| 217 | 230 | |
| 218 | 231 | #endif /* __PLATFORM_DATA_X86_ASUS_WMI_H */ |