The two 'goto setsym' statements are reachable only when sym == NULL. The code below the 'setsym:' label does nothing when sym == NULL since there is just one if-block guarded by 'if (sym && ...)'. Hence, 'goto setsym' can be replaced with 'continue'.
Showing the changes to scripts (1 of 1 file). Show all
Unified · Split
| @@ -363,7 +363,7 @@ load: · 362 unmodified lines | |||
| 363 | sym = sym_find(line + 2 + strlen(CONFIG_)); | 363 | sym = sym_find(line + 2 + strlen(CONFIG_)); |
| 364 | if (!sym) { | 364 | if (!sym) { |
| 365 | sym_add_change_count(1); | 365 | sym_add_change_count(1); |
| 366 | goto setsym; | 366 | continue; |
| 367 | } | 367 | } |
| 368 | } else { | 368 | } else { |
| 369 | sym = sym_lookup(line + 2 + strlen(CONFIG_), 0); | 369 | sym = sym_lookup(line + 2 + strlen(CONFIG_), 0); |
| @@ -397,7 +397,7 @@ load: · 27 unmodified lines | |||
| 397 | sym = sym_find(line + strlen(CONFIG_)); | 397 | sym = sym_find(line + strlen(CONFIG_)); |
| 398 | if (!sym) { | 398 | if (!sym) { |
| 399 | sym_add_change_count(1); | 399 | sym_add_change_count(1); |
| 400 | goto setsym; | 400 | continue; |
| 401 | } | 401 | } |
| 402 | } else { | 402 | } else { |
| 403 | sym = sym_lookup(line + strlen(CONFIG_), 0); | 403 | sym = sym_lookup(line + strlen(CONFIG_), 0); |
| @@ -416,7 +416,7 @@ load: · 12 unmodified lines | |||
| 416 | 416 | ||
| 417 | continue; | 417 | continue; |
| 418 | } | 418 | } |
| 419 | setsym: | 419 | |
| 420 | if (sym && sym_is_choice_value(sym)) { | 420 | if (sym && sym_is_choice_value(sym)) { |
| 421 | struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym)); | 421 | struct symbol *cs = prop_get_symbol(sym_get_choice_prop(sym)); |
| 422 | switch (sym->def[def].tri) { | 422 | switch (sym->def[def].tri) { |