statx: don't clear STATX_ATIME on SB_RDONLY

IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so generic_fillattr() will clear STATX_ATIME from the result_mask if the super block is marked read only. This was probably not the intention, so fix to only clear STATX_ATIME if the fs doesn't support atime at all.

Miklos Szeredi committed 6 years ago

Commit 761e28f1 parent 581701b1 file · +2 −1Browse files

Unified · Split

fs/stat.c+2−1

@@ -73,7 +73,8 @@ int vfs_getattr_nosec(const struct path path, struct kstat stat, · 72 unmodified lines
73	query_flags &= KSTAT_QUERY_FLAGS;	73	query_flags &= KSTAT_QUERY_FLAGS;
74		74
75	/* allow the fs to override these if it really wants to */	75	/* allow the fs to override these if it really wants to */
76	if (IS_NOATIME(inode))	76	/* SB_NOATIME means filesystem supplies dummy atime value */
		77	if (inode->i_sb->s_flags & SB_NOATIME)
77	stat->result_mask &= ~STATX_ATIME;	78	stat->result_mask &= ~STATX_ATIME;
78	if (IS_AUTOMOUNT(inode))	79	if (IS_AUTOMOUNT(inode))
79	stat->attributes \|= STATX_ATTR_AUTOMOUNT;	80	stat->attributes \|= STATX_ATTR_AUTOMOUNT;