History

xen: irqfd: Use _IOW instead of the internal _IOC() macro

_IOC() an internal helper that we should not use in driver code. In particular, we got the data direction wrong here, which breaks a number of tools, as having "_IOC_NONE" should never be paired with a nonzero size. Use _IOW() instead.

Viresh Kumar committed 3 years ago

Commit 767e33c1 parent 8dd765a1 file · +1 −1Browse files

Unified · Split

include/uapi/xen/privcmd.h+1−1
@@ -138,6 +138,6 @@ struct privcmd_irqfd { · 137 unmodified lines
138138 #define IOCTL_PRIVCMD_MMAP_RESOURCE \
139139 _IOC(_IOC_NONE, 'P', 7, sizeof(struct privcmd_mmap_resource))
140140 #define IOCTL_PRIVCMD_IRQFD \
141− _IOC(_IOC_NONE, 'P', 8, sizeof(struct privcmd_irqfd))
141+ _IOW('P', 8, struct privcmd_irqfd)
142142
143143 #endif /* __LINUX_PUBLIC_PRIVCMD_H__ */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t