History

checkpatch: refactor 'allowed asm includes' and add memory.h

Change the check suggesting replacement of asm-includes with linux-includes. Exceptions to this rule are easier to extend now. Add memory.h because ARM has a custom one.

Wolfram Sang committed 16 years ago

Commit 7840a941 parent 1986aaf1 file · +7 −1Browse files

Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all

Unified · Split

scripts/checkpatch.pl+7−1
@@ -224,6 +224,12 @@ our @modifierList = ( · 223 unmodified lines
224224 qr{fastcall},
225225 );
226226
227+our $allowed_asm_includes = qr{(?x:
228+ irq|
229+ memory
230+)};
231+# memory.h: ARM has a custom one
232+
227233 sub build_types {
228234 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
229235 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
@@ -2308,7 +2314,7 @@ sub process { · 2078 unmodified lines
23082314 my $checkfile = "include/linux/$file";
23092315 if (-f "$root/$checkfile" &&
23102316 $realfile ne $checkfile &&
2311− $1 ne 'irq')
2317+ $1 !~ /$allowed_asm_includes/)
23122318 {
23132319 if ($realfile =~ m{^arch/}) {
23142320 CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);