History

cfg80211: don't put kek/kck/replay counter on the stack

There's no need to put the values on the stack, just pass a pointer to the data in the nl80211 message. This reduces stack usage and avoids potential issues with putting sensitive data on the stack.

Johannes Berg committed 12 years ago

Commit 78f686c1 parent 538c9eb2 files · +7 −13Browse files

Showing the changes to include (1 of 2 files). Show all

Unified · Split

include/net/cfg80211.h+4−6
@@ -1980,14 +1980,12 @@ struct cfg80211_wowlan_wakeup { · 1979 unmodified lines
19801980
19811981 /**
19821982 * struct cfg80211_gtk_rekey_data - rekey data
1983− * @kek: key encryption key
1984− * @kck: key confirmation key
1985− * @replay_ctr: replay counter
1983+ * @kek: key encryption key (NL80211_KEK_LEN bytes)
1984+ * @kck: key confirmation key (NL80211_KCK_LEN bytes)
1985+ * @replay_ctr: replay counter (NL80211_REPLAY_CTR_LEN bytes)
19861986 */
19871987 struct cfg80211_gtk_rekey_data {
1988− u8 kek[NL80211_KEK_LEN];
1989− u8 kck[NL80211_KCK_LEN];
1990− u8 replay_ctr[NL80211_REPLAY_CTR_LEN];
1988+ const u8 *kek, *kck, *replay_ctr;
19911989 };
19921990
19931991 /**

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t