If clone_children is enabled, effective masks won't be initialized due to the bug: # mount -t cgroup -o cpuset xxx /mnt # echo 1 > cgroup.clone_children # mkdir /mnt/tmp # cat /mnt/tmp/ # cat cpuset.effective_cpus # cat cpuset.cpus 0-15 And then this cpuset won't constrain the tasks in it. Either the bug or the fix has no effect on unified hierarchy, as there's no clone_chidren flag there any more.
Unified · Split
| @@ -1979,7 +1979,9 @@ static int cpuset_css_online(struct cgroup_subsys_state *css) · 1978 unmodified lines | |||
| 1979 | 1979 | ||
| 1980 | spin_lock_irq(&callback_lock); | 1980 | spin_lock_irq(&callback_lock); |
| 1981 | cs->mems_allowed = parent->mems_allowed; | 1981 | cs->mems_allowed = parent->mems_allowed; |
| 1982 | cs->effective_mems = parent->mems_allowed; | ||
| 1982 | cpumask_copy(cs->cpus_allowed, parent->cpus_allowed); | 1983 | cpumask_copy(cs->cpus_allowed, parent->cpus_allowed); |
| 1984 | cpumask_copy(cs->effective_cpus, parent->cpus_allowed); | ||
| 1983 | spin_unlock_irq(&callback_lock); | 1985 | spin_unlock_irq(&callback_lock); |
| 1984 | out_unlock: | 1986 | out_unlock: |
| 1985 | mutex_unlock(&cpuset_mutex); | 1987 | mutex_unlock(&cpuset_mutex); |