We remove the waiting module removal in commit 3f2b9c9cdf38 (September 2013), but it turns out that modprobe in kmod (< version 16) was asking for waiting module removal. No one noticed since modprobe would check for 0 usage immediately before trying to remove the module, and the race is unlikely. However, it means that anyone running old (but not ancient) kmod versions is hitting the printk designed to see if anyone was running "rmmod -w". All reports so far have been false positives, so remove the warning.
Showing the changes to kernel/module.c (1 of 1 file). Show all
Unified · Split
| @@ -815,9 +815,6 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user, · 814 unmodified lines | ||
| 815 | 815 | return -EFAULT; |
| 816 | 816 | name[MODULE_NAME_LEN-1] = '\0'; |
| 817 | 817 | |
| 818 | − if (!(flags & O_NONBLOCK)) | |
| 819 | − pr_warn("waiting module removal not supported: please upgrade\n"); | |
| 820 | − | |
| 821 | 818 | if (mutex_lock_interruptible(&module_mutex) != 0) |
| 822 | 819 | return -EINTR; |
| 823 | 820 | |