When CONFIG_PM_SLEEP is not set, there is a warning that qcom_ipcc_pm_resume() is unused: drivers/mailbox/qcom-ipcc.c:258:12: error: 'qcom_ipcc_pm_resume' defined but not used [-Werror=unused-function] 258 | static int qcom_ipcc_pm_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") reworked the PM_OPS macros to avoid this problem. Use NOIRQ_SYSTEM_SLEEP_PM_OPS directly so that qcom_ipcc_pm_resume() always appears to be used to the compiler, even though it will be dead code eliminated in the !CONFIG_PM_SLEEP case.
Unified · Split
| @@ -344,7 +344,7 @@ static const struct of_device_id qcom_ipcc_of_match[] = { · 343 unmodified lines | |||
| 344 | MODULE_DEVICE_TABLE(of, qcom_ipcc_of_match); | 344 | MODULE_DEVICE_TABLE(of, qcom_ipcc_of_match); |
| 345 | 345 | ||
| 346 | static const struct dev_pm_ops qcom_ipcc_dev_pm_ops = { | 346 | static const struct dev_pm_ops qcom_ipcc_dev_pm_ops = { |
| 347 | SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(NULL, qcom_ipcc_pm_resume) | 347 | NOIRQ_SYSTEM_SLEEP_PM_OPS(NULL, qcom_ipcc_pm_resume) |
| 348 | }; | 348 | }; |
| 349 | 349 | ||
| 350 | static struct platform_driver qcom_ipcc_driver = { | 350 | static struct platform_driver qcom_ipcc_driver = { |