printk specifier %p now hashes all addresses before printing. Sometimes we need to see the actual unmodified address. This can be achieved using %lx but then we face the risk that if in future we want to change the way the Kernel handles printing of pointers we will have to grep through the already existent 50 000 %lx call sites. Let's add specifier %px as a clear, opt-in, way to print a pointer and maintain some level of isolation from all the other hex integer output within the Kernel. Add printk specifier %px to print the actual unmodified address.
Showing the changes to scripts/checkpatch.pl (1 of 3 files). Show all
Unified · Split
| @@ -5753,7 +5753,7 @@ sub process { · 5752 unmodified lines | ||
| 5753 | 5753 | for (my $count = $linenr; $count <= $lc; $count++) { |
| 5754 | 5754 | my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0)); |
| 5755 | 5755 | $fmt =~ s/%%//g; |
| 5756 | − if ($fmt =~ /(\%[\*\d\.]*p(?![\WFfSsBKRraEhMmIiUDdgVCbGNO]).)/) { | |
| 5756 | + if ($fmt =~ /(\%[\*\d\.]*p(?![\WFfSsBKRraEhMmIiUDdgVCbGNOx]).)/) { | |
| 5757 | 5757 | $bad_extension = $1; |
| 5758 | 5758 | last; |
| 5759 | 5759 | } |