History

Merge tag 'md/4.1-rc7-fixes' of git://neil.brown.name/md

Pull three more md fixes from Neil Brown: "Hasn't been a good cycle for md has it :-( The main issue fixed here is a rare race which can result in two reshape threads running at once, which doesn't end well. Also a minor issue with a write to a sysfs file returning the wrong value. Backports to 4.0-stable are indicated" * tag 'md/4.1-rc7-fixes' of git://neil.brown.name/md: md: make sure MD_RECOVERY_DONE is clear before starting recovery/resync md: Close race when setting 'action' to 'idle'. md: don't return 0 from array_state_store

Linus Torvalds committed 11 years ago

Commit 7b565d92 parents c39f3bc ea358cd3 files · +10 −6Browse files

Unified · Split

3 files
  1. drivers/md/md.c +8 −6
  2. drivers/md/raid10.c +1 −0
  3. drivers/md/raid5.c +1 −0
drivers/md/md.c+8−6
@@ -3834,7 +3834,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len) · 3833 unmodified lines
38343834 err = -EBUSY;
38353835 }
38363836 spin_unlock(&mddev->lock);
3837− return err;
3837+ return err ?: len;
38383838 }
38393839 err = mddev_lock(mddev);
38403840 if (err)
@@ -4217,13 +4217,14 @@ action_store(struct mddev *mddev, const char *page, size_t len) · 376 unmodified lines
42174217 set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
42184218 else
42194219 clear_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
4220− flush_workqueue(md_misc_wq);
4221− if (mddev->sync_thread) {
4222− set_bit(MD_RECOVERY_INTR, &mddev->recovery);
4223− if (mddev_lock(mddev) == 0) {
4220+ if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) &&
4221+ mddev_lock(mddev) == 0) {
4222+ flush_workqueue(md_misc_wq);
4223+ if (mddev->sync_thread) {
4224+ set_bit(MD_RECOVERY_INTR, &mddev->recovery);
42244225 md_reap_sync_thread(mddev);
4225− mddev_unlock(mddev);
42264226 }
4227+ mddev_unlock(mddev);
42274228 }
42284229 } else if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) ||
42294230 test_bit(MD_RECOVERY_NEEDED, &mddev->recovery))
@@ -8261,6 +8262,7 @@ void md_reap_sync_thread(struct mddev *mddev) · 4031 unmodified lines
82618262 if (mddev_is_clustered(mddev))
82628263 md_cluster_ops->metadata_update_finish(mddev);
82638264 clear_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
8265+ clear_bit(MD_RECOVERY_DONE, &mddev->recovery);
82648266 clear_bit(MD_RECOVERY_SYNC, &mddev->recovery);
82658267 clear_bit(MD_RECOVERY_RESHAPE, &mddev->recovery);
82668268 clear_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
drivers/md/raid10.c+1−0
@@ -4156,6 +4156,7 @@ static int raid10_start_reshape(struct mddev *mddev) · 4155 unmodified lines
41564156
41574157 clear_bit(MD_RECOVERY_SYNC, &mddev->recovery);
41584158 clear_bit(MD_RECOVERY_CHECK, &mddev->recovery);
4159+ clear_bit(MD_RECOVERY_DONE, &mddev->recovery);
41594160 set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery);
41604161 set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
41614162
drivers/md/raid5.c+1−0
@@ -7354,6 +7354,7 @@ static int raid5_start_reshape(struct mddev *mddev) · 7353 unmodified lines
73547354
73557355 clear_bit(MD_RECOVERY_SYNC, &mddev->recovery);
73567356 clear_bit(MD_RECOVERY_CHECK, &mddev->recovery);
7357+ clear_bit(MD_RECOVERY_DONE, &mddev->recovery);
73577358 set_bit(MD_RECOVERY_RESHAPE, &mddev->recovery);
73587359 set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
73597360 mddev->sync_thread = md_register_thread(md_do_sync, mddev,

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t