History

IB/mlx5: Add support for DEVX query UAR

Return a device UAR index for a given user index via the DEVX interface. Security note: The hardware protection mechanism works like this: Each device object that is subject to UAR doorbells (QP/SQ/CQ) gets a UAR ID (called uar_page in the device specification manual) upon its creation. Then upon doorbell, hardware fetches the object context for which the doorbell was rang, and validates that the UAR through which the DB was rang matches the UAR ID of the object. If no match the doorbell is silently ignored by the hardware. Of course, the user cannot ring a doorbell on a UAR that was not mapped to it. Now in devx, as the devx kernel does not manipulate the QP/SQ/CQ command mailboxes (except tagging them with UID), we expose to the user its UAR ID, so it can embed it in these objects in the expected specification format. So the only thing the user can do is hurt itself by creating a QP/SQ/CQ with a UAR ID other than his, and then in this case other users may ring a doorbell on its objects. The consequence of that will be that another user can schedule a QP/SQ of the buggy user for execution (just insert it to the hardware schedule queue or arm its CQ for event generation), no further harm is expected.

Yishai Hadas committed 8 years ago

Commit 7c043e91 parent e662e144 files · +67 −4Browse files

Showing the changes to include/uapi (1 of 4 files). Show all

Unified · Split

include/uapi/rdma/mlx5_user_ioctl_cmds.h+6−0
@@ -47,6 +47,7 @@ enum mlx5_ib_alloc_dm_attrs { · 46 unmodified lines
4747
4848 enum mlx5_ib_devx_methods {
4949 MLX5_IB_METHOD_DEVX_OTHER = (1U << UVERBS_ID_NS_SHIFT),
50+ MLX5_IB_METHOD_DEVX_QUERY_UAR,
5051 };
5152
5253 enum mlx5_ib_devx_other_attrs {
@@ -60,6 +61,11 @@ enum mlx5_ib_devx_obj_create_attrs { · 7 unmodified lines
6061 MLX5_IB_ATTR_DEVX_OBJ_CREATE_CMD_OUT,
6162 };
6263
64+enum mlx5_ib_devx_query_uar_attrs {
65+ MLX5_IB_ATTR_DEVX_QUERY_UAR_USER_IDX = (1U << UVERBS_ID_NS_SHIFT),
66+ MLX5_IB_ATTR_DEVX_QUERY_UAR_DEV_IDX,
67+};
68+
6369 enum mlx5_ib_devx_obj_destroy_attrs {
6470 MLX5_IB_ATTR_DEVX_OBJ_DESTROY_HANDLE = (1U << UVERBS_ID_NS_SHIFT),
6571 };

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t