History

bdi: Drop 'parent' argument from bdi_register[_va]()

Drop 'parent' argument of bdi_register() and bdi_register_va(). It is always NULL.

Jan Kara committed 9 years ago

Commit 7c4cc301 parent 2e82b844 files · +11 −15Browse files

Unified · Split

4 files
  1. drivers/mtd/mtdcore.c +1 −1
  2. fs/super.c +1 −1
  3. include/linux/backing-dev.h +4 −5
  4. mm/backing-dev.c +5 −8
drivers/mtd/mtdcore.c+1−1
@@ -1782,7 +1782,7 @@ static struct backing_dev_info * __init mtd_bdi_init(char *name) · 1781 unmodified lines
17821782 * We put '-0' suffix to the name to get the same name format as we
17831783 * used to get. Since this is called only once, we get a unique name.
17841784 */
1785− ret = bdi_register(bdi, NULL, "%.28s-0", name);
1785+ ret = bdi_register(bdi, "%.28s-0", name);
17861786 if (ret)
17871787 bdi_put(bdi);
17881788
fs/super.c+1−1
@@ -1272,7 +1272,7 @@ int super_setup_bdi_name(struct super_block *sb, char *fmt, ...) · 1271 unmodified lines
12721272 bdi->name = sb->s_type->name;
12731273
12741274 va_start(args, fmt);
1275− err = bdi_register_va(bdi, NULL, fmt, args);
1275+ err = bdi_register_va(bdi, fmt, args);
12761276 va_end(args);
12771277 if (err) {
12781278 bdi_put(bdi);
include/linux/backing-dev.h+4−5
@@ -25,11 +25,10 @@ static inline struct backing_dev_info *bdi_get(struct backing_dev_info *bdi) · 24 unmodified lines
2525
2626 void bdi_put(struct backing_dev_info *bdi);
2727
28−__printf(3, 4)
29−int bdi_register(struct backing_dev_info *bdi, struct device *parent,
30− const char *fmt, ...);
31−int bdi_register_va(struct backing_dev_info *bdi, struct device *parent,
32− const char *fmt, va_list args);
28+__printf(2, 3)
29+int bdi_register(struct backing_dev_info *bdi, const char *fmt, ...);
30+int bdi_register_va(struct backing_dev_info *bdi, const char *fmt,
31+ va_list args);
3332 int bdi_register_owner(struct backing_dev_info *bdi, struct device *owner);
3433 void bdi_unregister(struct backing_dev_info *bdi);
3534
mm/backing-dev.c+5−8
@@ -856,15 +856,14 @@ struct backing_dev_info *bdi_alloc_node(gfp_t gfp_mask, int node_id) · 855 unmodified lines
856856 }
857857 EXPORT_SYMBOL(bdi_alloc_node);
858858
859−int bdi_register_va(struct backing_dev_info *bdi, struct device *parent,
860− const char *fmt, va_list args)
859+int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
861860 {
862861 struct device *dev;
863862
864863 if (bdi->dev) /* The driver needs to use separate queues per device */
865864 return 0;
866865
867− dev = device_create_vargs(bdi_class, parent, MKDEV(0, 0), bdi, fmt, args);
866+ dev = device_create_vargs(bdi_class, NULL, MKDEV(0, 0), bdi, fmt, args);
868867 if (IS_ERR(dev))
869868 return PTR_ERR(dev);
870869
@@ -883,14 +882,13 @@ int bdi_register_va(struct backing_dev_info *bdi, struct device *parent, · 12 unmodified lines
883882 }
884883 EXPORT_SYMBOL(bdi_register_va);
885884
886−int bdi_register(struct backing_dev_info *bdi, struct device *parent,
887− const char *fmt, ...)
885+int bdi_register(struct backing_dev_info *bdi, const char *fmt, ...)
888886 {
889887 va_list args;
890888 int ret;
891889
892890 va_start(args, fmt);
893− ret = bdi_register_va(bdi, parent, fmt, args);
891+ ret = bdi_register_va(bdi, fmt, args);
894892 va_end(args);
895893 return ret;
896894 }
@@ -900,8 +898,7 @@ int bdi_register_owner(struct backing_dev_info *bdi, struct device *owner) · 3 unmodified lines
900898 {
901899 int rc;
902900
903− rc = bdi_register(bdi, NULL, "%u:%u", MAJOR(owner->devt),
904− MINOR(owner->devt));
901+ rc = bdi_register(bdi, "%u:%u", MAJOR(owner->devt), MINOR(owner->devt));
905902 if (rc)
906903 return rc;
907904 /* Leaking owner reference... */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t