net/mlx4_en: Code cleanups in tx path

- Remove unused variable ring->poll_cnt - No need to set some fields if using blueflame - Add missing const's - Use unlikely - Remove unneeded new line - Make some comments more precise - struct mlx4_bf @offset field reduced to unsigned int to save space

Eric Dumazet committed 12 years ago

Commit 7dfa4b41 parent f2600cf3 files · +27 −25Browse files

Unified · Split

3 files

drivers/net/ethernet/mellanox/mlx4/en_tx.c +26 −23
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h +0 −1
include/linux/mlx4/device.h +1 −1

drivers/net/ethernet/mellanox/mlx4/en_tx.c+26−23

 	ring->prod = 0;
 	ring->cons = 0xffffffff;
 	ring->last_nr_txbb = 1;
-	ring->poll_cnt = 0;
 	memset(ring->tx_info, 0, ring->size * sizeof(struct mlx4_en_tx_info));
 	memset(ring->buf, 0, ring->buf_size);
 	return ring->buf + index * TXBB_SIZE;
 }
-static int is_inline(int inline_thold, struct sk_buff *skb, void **pfrag)
+static bool is_inline(int inline_thold, const struct sk_buff *skb,
+		      void **pfrag)
 {
 	void *ptr;
 	return 0;
 }
-static int inline_size(struct sk_buff *skb)
+static int inline_size(const struct sk_buff *skb)
 {
 	if (skb->len + CTRL_SIZE + sizeof(struct mlx4_wqe_inline_seg)
 	    <= MLX4_INLINE_ALIGN)
 			     sizeof(struct mlx4_wqe_inline_seg), 16);
 }
-static int get_real_size(struct sk_buff *skb, struct net_device *dev,
+static int get_real_size(const struct sk_buff *skb,
+			 struct net_device *dev,
 			 int *lso_header_size)
 {
 	struct mlx4_en_priv *priv = netdev_priv(dev);
 	return real_size;
 }
-static void build_inline_wqe(struct mlx4_en_tx_desc *tx_desc, struct sk_buff *skb,
+static void build_inline_wqe(struct mlx4_en_tx_desc *tx_desc,
-			     int real_size, u16 *vlan_tag, int tx_ind, void *fragptr)
+			     const struct sk_buff *skb,
+			     int real_size, u16 *vlan_tag,
+			     int tx_ind, void *fragptr)
 {
 	struct mlx4_wqe_inline_seg *inl = &tx_desc->inl;
 	int spc = MLX4_INLINE_ALIGN - CTRL_SIZE - sizeof *inl;
 	return fallback(dev, skb) % rings_p_up + up * rings_p_up;
 }
-static void mlx4_bf_copy(void __iomem *dst, unsigned long *src, unsigned bytecnt)
+static void mlx4_bf_copy(void __iomem *dst, const void *src,
+			 unsigned int bytecnt)
 {
 	__iowrite64_copy(dst, src, bytecnt / 8);
 }
 	tx_info->skb = skb;
 	tx_info->nr_txbb = nr_txbb;
+	data = &tx_desc->data;
 	if (lso_header_size)
 		data = ((void *)&tx_desc->lso + ALIGN(lso_header_size + 4,
 						      DS_SIZE));
-	else
-		data = &tx_desc->data;
 	/* valid only for none inline segments */
 	tx_info->data_offset = (void *)data - (void *)tx_desc;
 	if (is_inline(ring->inline_thold, skb, &fragptr)) {
 		tx_info->inl = 1;
 	} else {
-		/* Map fragments */
+		/* Map fragments if any */
 		for (i = skb_shinfo(skb)->nr_frags - 1; i >= 0; i--) {
-			struct skb_frag_struct *frag;
+			const struct skb_frag_struct *frag;
 			dma_addr_t dma;
 			frag = &skb_shinfo(skb)->frags[i];
 			--data;
 		}
-		/* Map linear part */
+		/* Map linear part if needed */
 		if (tx_info->linear) {
 			u32 byte_count = skb_headlen(skb) - lso_header_size;
 			dma_addr_t dma;
 	 * For timestamping add flag to skb_shinfo and
 	 * set flag for further reference
 	 */
-	if (ring->hwtstamp_tx_type == HWTSTAMP_TX_ON &&
+	if (unlikely(ring->hwtstamp_tx_type == HWTSTAMP_TX_ON &&
-	    skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) {
+		     shinfo->tx_flags & SKBTX_HW_TSTAMP)) {
-		skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;
+		shinfo->tx_flags |= SKBTX_IN_PROGRESS;
 		tx_info->ts_requested = 1;
 	}
 	/* Prepare ctrl segement apart opcode+ownership, which depends on
 	 * whether LSO is used */
-	tx_desc->ctrl.vlan_tag = cpu_to_be16(vlan_tag);
-	tx_desc->ctrl.ins_vlan = MLX4_WQE_CTRL_INS_VLAN *
-		!!vlan_tx_tag_present(skb);
-	tx_desc->ctrl.fence_size = (real_size / 16) & 0x3f;
 	tx_desc->ctrl.srcrb_flags = priv->ctrl_flags;
 	if (likely(skb->ip_summed == CHECKSUM_PARTIAL)) {
 		tx_desc->ctrl.srcrb_flags |= cpu_to_be32(MLX4_WQE_CTRL_IP_CSUM |
 			 cpu_to_be32(MLX4_EN_BIT_DESC_OWN) : 0);
 		tx_info->nr_bytes = max_t(unsigned int, skb->len, ETH_ZLEN);
 		ring->packets++;
 	}
 	ring->bytes += tx_info->nr_bytes;
 	netdev_tx_sent_queue(ring->tx_queue, tx_info->nr_bytes);
 	ring->prod += nr_txbb;
 	/* If we used a bounce buffer then copy descriptor back into place */
-	if (bounce)
+	if (unlikely(bounce))
 		tx_desc = mlx4_en_bounce_to_desc(priv, ring, index, desc_size);
 	skb_tx_timestamp(skb);
 		wmb();
-		mlx4_bf_copy(ring->bf.reg + ring->bf.offset, (unsigned long *) &tx_desc->ctrl,
+		mlx4_bf_copy(ring->bf.reg + ring->bf.offset, &tx_desc->ctrl,
-		     desc_size);
+			     desc_size);
 		wmb();
 		ring->bf.offset ^= ring->bf.buf_size;
 	} else {
+		tx_desc->ctrl.vlan_tag = cpu_to_be16(vlan_tag);
+		tx_desc->ctrl.ins_vlan = MLX4_WQE_CTRL_INS_VLAN *
+			!!vlan_tx_tag_present(skb);
+		tx_desc->ctrl.fence_size = real_size;
 		/* Ensure new descriptor hits memory
 		 * before setting ownership of this descriptor to HW
 		 */

drivers/net/ethernet/mellanox/mlx4/mlx4_en.h+0−1

@@ -263,7 +263,6 @@ struct mlx4_en_tx_ring { · 262 unmodified lines
263	u32 buf_size;	263	u32 buf_size;
264	u32 doorbell_qpn;	264	u32 doorbell_qpn;
265	void *buf;	265	void *buf;
266	u16 poll_cnt;
267	struct mlx4_en_tx_info *tx_info;	266	struct mlx4_en_tx_info *tx_info;
268	u8 *bounce_buf;	267	u8 *bounce_buf;
269	u8 queue_index;	268	u8 queue_index;

include/linux/mlx4/device.h+1−1

@@ -583,7 +583,7 @@ struct mlx4_uar { · 582 unmodified lines
583	};	583	};
584		584
585	struct mlx4_bf {	585	struct mlx4_bf {
586	unsigned long offset;	586	unsigned int offset;
587	int buf_size;	587	int buf_size;
588	struct mlx4_uar *uar;	588	struct mlx4_uar *uar;
589	void __iomem *reg;	589	void __iomem *reg;

net/mlx4_en: Code cleanups in tx path

Keyboard shortcuts

General

Issues and pull requests

Issues, pull requests and Inbox

Repository code