History

ARM: OMAP2+: Fix LCD panel backlight regression for LDP legacy booting

Looks like the LCD panel on LDP has been broken quite a while, and recently got fixed by commit 0b2aa8bed3e1 (gpio: twl4030: Fix regression for twl gpio output). However, there's still an issue left where the panel backlight does not come on if the LCD drivers are built into the kernel. Fix the issue by registering the DPI LCD panel only after the twl4030 GPIO has probed.

Tony Lindgren committed 12 years ago

Commit 7e367c11 parent 413541d1 file · +6 −1Browse files

Unified · Split

arch/arm/mach-omap2/board-ldp.c+6−1
@@ -242,12 +242,18 @@ static void __init ldp_display_init(void) · 241 unmodified lines
242242
243243 static int ldp_twl_gpio_setup(struct device *dev, unsigned gpio, unsigned ngpio)
244244 {
245+ int res;
246+
245247 /* LCD enable GPIO */
246248 ldp_lcd_pdata.enable_gpio = gpio + 7;
247249
248250 /* Backlight enable GPIO */
249251 ldp_lcd_pdata.backlight_gpio = gpio + 15;
250252
253+ res = platform_device_register(&ldp_lcd_device);
254+ if (res)
255+ pr_err("Unable to register LCD: %d\n", res);
256+
251257 return 0;
252258 }
253259
@@ -346,7 +352,6 @@ static struct omap2_hsmmc_info mmc[] __initdata = { · 92 unmodified lines
346352
347353 static struct platform_device *ldp_devices[] __initdata = {
348354 &ldp_gpio_keys_device,
349− &ldp_lcd_device,
350355 };
351356
352357 #ifdef CONFIG_OMAP_MUX

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t