Emit a warning when a signature is used more than once.
Showing the changes to scripts/checkpatch.pl (1 of 1 file). Show all
Unified · Split
| @@ -1544,6 +1544,7 @@ sub process { · 1543 unmodified lines | ||
| 1544 | 1544 | my %suppress_export; |
| 1545 | 1545 | my $suppress_statement = 0; |
| 1546 | 1546 | |
| 1547 | + my %signatures = (); | |
| 1547 | 1548 | |
| 1548 | 1549 | # Pre-scan the patch sanitizing the lines. |
| 1549 | 1550 | # Pre-scan the patch looking for any __setup documentation. |
| @@ -1793,6 +1794,17 @@ sub process { · 243 unmodified lines | ||
| 1793 | 1794 | "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr); |
| 1794 | 1795 | } |
| 1795 | 1796 | } |
| 1797 | + | |
| 1798 | +# Check for duplicate signatures | |
| 1799 | + my $sig_nospace = $line; | |
| 1800 | + $sig_nospace =~ s/\s//g; | |
| 1801 | + $sig_nospace = lc($sig_nospace); | |
| 1802 | + if (defined $signatures{$sig_nospace}) { | |
| 1803 | + WARN("BAD_SIGN_OFF", | |
| 1804 | + "Duplicate signature\n" . $herecurr); | |
| 1805 | + } else { | |
| 1806 | + $signatures{$sig_nospace} = 1; | |
| 1807 | + } | |
| 1796 | 1808 | } |
| 1797 | 1809 | |
| 1798 | 1810 | # Check for wrappage within a valid hunk of the file |