It may process IPv4 TCP GSO packets in cipso_v4_skbuff_setattr(), so the iph->tot_len update should use iph_set_totlen(). Note that for these non GSO packets, the new iph tot_len with extra iph option len added may become greater than 65535, the old process will cast it and set iph->tot_len to it, which is a bug. In theory, iph options shouldn't be added for these big packets in here, a fix may be needed here in the future. For now this patch is only to set iph->tot_len to 0 when it happens.
Unified · Split
| @@ -2222,7 +2222,7 @@ int cipso_v4_skbuff_setattr(struct sk_buff *skb, · 2221 unmodified lines | |||
| 2222 | memset((char *)(iph + 1) + buf_len, 0, opt_len - buf_len); | 2222 | memset((char *)(iph + 1) + buf_len, 0, opt_len - buf_len); |
| 2223 | if (len_delta != 0) { | 2223 | if (len_delta != 0) { |
| 2224 | iph->ihl = 5 + (opt_len >> 2); | 2224 | iph->ihl = 5 + (opt_len >> 2); |
| 2225 | iph->tot_len = htons(skb->len); | 2225 | iph_set_totlen(iph, skb->len); |
| 2226 | } | 2226 | } |
| 2227 | ip_send_check(iph); | 2227 | ip_send_check(iph); |
| 2228 | 2228 | ||