History

verification/rvgen: Remove the old state variables

The state variables (states, initial_state, final_states) only capture the states' names and have less information than their Lark-based counterparts. Switch to use the new state variables and delete these old ones.

Nam Cao committed 4 months ago

Commit 7edaba01 parent cad252d3 files · +13 −14Browse files

Unified · Split

3 files
  1. tools/verification/rvgen/rvgen/automata.py +4 −5
  2. tools/verification/rvgen/rvgen/dot2c.py +5 −5
  3. tools/verification/rvgen/rvgen/dot2k.py +4 −4
tools/verification/rvgen/rvgen/automata.py+4−5
@@ -411,8 +411,7 @@ class Automata: · 410 unmodified lines
411411 self.__dot_lines = self.__open_dot()
412412 self.__parse_tree = ParseTree(file_path)
413413 self.transitions = self.__parse_transitions()
414− self._states, self._initial_state, self._final_states = self.__parse_states()
415− self.states, self.initial_state, self.final_states = self.__get_state_variables()
414+ self.states, self.initial_state, self.final_states = self.__parse_states()
416415 self.env_types = {}
417416 self.env_stored = set()
418417 self.constraint_vars = set()
@@ -603,7 +602,7 @@ class Automata: · 184 unmodified lines
603602 envs.append(c.env)
604603 self.__extract_env_var(c)
605604
606− for state in self._states:
605+ for state in self.states:
607606 if state.inv:
608607 envs.append(state.inv.env)
609608 self.__extract_env_var(state.inv)
@@ -639,7 +638,7 @@ class Automata: · 29 unmodified lines
639638 def __create_matrix(self) -> list[list[str]]:
640639 # transform the array into a dictionary
641640 events = self.events
642− states = [s.name for s in self._states]
641+ states = [s.name for s in self.states]
643642 events_dict = {}
644643 states_dict = {}
645644 nr_event = 0
@@ -675,7 +674,7 @@ class Automata: · 29 unmodified lines
675674 for j in range(len(self.states)):
676675 if self.function[j][i] != self.invalid_state_str:
677676 curr_event_used += 1
678− if self.function[j][i] == self.initial_state:
677+ if self.function[j][i] == self.initial_state.name:
679678 curr_event_will_init += 1
680679 if self.function[0][i] != self.invalid_state_str:
681680 curr_event_from_init = True
tools/verification/rvgen/rvgen/dot2c.py+5−5
@@ -29,10 +29,10 @@ class Dot2c(Automata): · 28 unmodified lines
2929
3030 def __get_enum_states_content(self) -> list[str]:
3131 buff = []
32− buff.append(f"\t{self.initial_state}{self.enum_suffix},")
32+ buff.append(f"\t{self.initial_state.name}{self.enum_suffix},")
3333 for state in self.states:
3434 if state != self.initial_state:
35− buff.append(f"\t{state}{self.enum_suffix},")
35+ buff.append(f"\t{state.name}{self.enum_suffix},")
3636 buff.append(f"\tstate_max{self.enum_suffix},")
3737
3838 return buff
@@ -142,7 +142,7 @@ class Dot2c(Automata): · 103 unmodified lines
142142 def format_aut_init_states_string(self) -> list[str]:
143143 buff = []
144144 buff.append("\t.state_names = {")
145− buff.append(self.__get_string_vector_per_line_content(self.states))
145+ buff.append(self.__get_string_vector_per_line_content([s.name for s in self.states]))
146146 buff.append("\t},")
147147
148148 return buff
@@ -159,7 +159,7 @@ class Dot2c(Automata): · 10 unmodified lines
159159 return buff
160160
161161 def __get_max_strlen_of_states(self) -> int:
162− max_state_name = len(max(self.states, key=len))
162+ max_state_name = max((len(s.name) for s in self.states))
163163 return max(max_state_name, len(self.invalid_state_str))
164164
165165 def get_aut_init_function(self) -> str:
@@ -199,7 +199,7 @@ class Dot2c(Automata): · 33 unmodified lines
199199 return buff
200200
201201 def get_aut_init_initial_state(self) -> str:
202− return self.initial_state
202+ return self.initial_state.name
203203
204204 def format_aut_init_initial_state(self) -> list[str]:
205205 buff = []
tools/verification/rvgen/rvgen/dot2k.py+4−4
@@ -179,7 +179,7 @@ class ha2k(dot2k): · 178 unmodified lines
179179 self.trace_h = self._read_template_file("trace_hybrid.h")
180180 self.has_invariant = False
181181 self.has_guard = False
182− for state in self._states:
182+ for state in self.states:
183183 if state.inv:
184184 self.has_invariant = True
185185 for transition in self.transitions:
@@ -318,7 +318,7 @@ f"""static inline bool ha_verify_invariants(struct ha_monitor *ha_mon, · 132 unmodified lines
318318 {{"""]
319319
320320 _else = ""
321− for state in self._states:
321+ for state in self.states:
322322 if not state.inv:
323323 continue
324324
@@ -386,7 +386,7 @@ f"""static inline void ha_setup_invariants(struct ha_monitor *ha_mon, · 61 unmodified lines
386386 buff.append(f"\tif ({condition_str})\n\t\treturn;")
387387
388388 _else = ""
389− for state in self._states:
389+ for state in self.states:
390390 inv = state.inv
391391 if not inv:
392392 continue
@@ -395,7 +395,7 @@ f"""static inline void ha_setup_invariants(struct ha_monitor *ha_mon, · 2 unmodified lines
395395 buff.append(f"\t\t{inv};")
396396 _else = "else "
397397
398− for state in self._states:
398+ for state in self.states:
399399 inv = state.inv
400400 if not inv:
401401 continue