The HID descriptor of many of Wacom's touch input devices include a "Confidence" usage that signals if a particular touch collection contains useful data. The driver does not look at this flag, however, which causes even invalid contacts to be reported to userspace. A lucky combination of kernel event filtering and device behavior (specifically: contact ID 0 == invalid, contact ID >0 == valid; and order all data so that all valid contacts are reported before any invalid contacts) spare most devices from any visibly-bad behavior. The DTH-2452 is one example of an unlucky device that misbehaves. It uses ID 0 for both the first valid contact and all invalid contacts. Because we report both the valid and invalid contacts, the kernel reports that contact 0 first goes down (valid) and then goes up (invalid) in every report. This causes ~100 clicks per second simply by touching the screen. This patch inroduces new `confidence` flag in our `hid_data` structure. The value is initially set to `true` at the start of a report and can be set to `false` if an invalid touch usage is seen.
Unified · Split
| @@ -2603,6 +2603,9 @@ static void wacom_wac_finger_event(struct hid_device *hdev, · 2602 unmodified lines | |||
| 2603 | return; | 2603 | return; |
| 2604 | 2604 | ||
| 2605 | switch (equivalent_usage) { | 2605 | switch (equivalent_usage) { |
| 2606 | case HID_DG_CONFIDENCE: | ||
| 2607 | wacom_wac->hid_data.confidence = value; | ||
| 2608 | break; | ||
| 2606 | case HID_GD_X: | 2609 | case HID_GD_X: |
| 2607 | wacom_wac->hid_data.x = value; | 2610 | wacom_wac->hid_data.x = value; |
| 2608 | break; | 2611 | break; |
| @@ -2635,7 +2638,8 @@ static void wacom_wac_finger_event(struct hid_device *hdev, · 26 unmodified lines | |||
| 2635 | } | 2638 | } |
| 2636 | 2639 | ||
| 2637 | if (usage->usage_index + 1 == field->report_count) { | 2640 | if (usage->usage_index + 1 == field->report_count) { |
| 2638 | if (equivalent_usage == wacom_wac->hid_data.last_slot_field) | 2641 | if (equivalent_usage == wacom_wac->hid_data.last_slot_field && |
| 2642 | wacom_wac->hid_data.confidence) | ||
| 2639 | wacom_wac_finger_slot(wacom_wac, wacom_wac->touch_input); | 2643 | wacom_wac_finger_slot(wacom_wac, wacom_wac->touch_input); |
| 2640 | } | 2644 | } |
| 2641 | } | 2645 | } |
| @@ -2653,6 +2657,8 @@ static void wacom_wac_finger_pre_report(struct hid_device *hdev, · 11 unmodified lines | |||
| 2653 | 2657 | ||
| 2654 | wacom_wac->is_invalid_bt_frame = false; | 2658 | wacom_wac->is_invalid_bt_frame = false; |
| 2655 | 2659 | ||
| 2660 | hid_data->confidence = true; | ||
| 2661 | |||
| 2656 | for (i = 0; i < report->maxfield; i++) { | 2662 | for (i = 0; i < report->maxfield; i++) { |
| 2657 | struct hid_field *field = report->field[i]; | 2663 | struct hid_field *field = report->field[i]; |
| 2658 | int j; | 2664 | int j; |
| @@ -301,6 +301,7 @@ struct hid_data { · 300 unmodified lines | |||
| 301 | bool barrelswitch; | 301 | bool barrelswitch; |
| 302 | bool barrelswitch2; | 302 | bool barrelswitch2; |
| 303 | bool serialhi; | 303 | bool serialhi; |
| 304 | bool confidence; | ||
| 304 | int x; | 305 | int x; |
| 305 | int y; | 306 | int y; |
| 306 | int pressure; | 307 | int pressure; |