The structure is packed, which requires that all its fields need to be also packed. ./include/uapi/linux/videodev2.h:1810:2: warning: field within 'struct v4l2_ext_control' is less aligned than 'union v4l2_ext_control::(anonymous at ./include/uapi/linux/videodev2.h:1810:2)' and is usually due to 'struct v4l2_ext_control' being packed, which can lead to unaligned accesses [-Wunaligned-access] Explicitly set the inner union as packed. Marking the inner union as 'packed' does not change the layout, since the whole struct is already packed, it just silences the clang warning. See also this llvm discussion: https://github.com/llvm/llvm-project/issues/55520
Showing the changes to include/uapi (1 of 1 file). Show all
Unified · Split
| @@ -1842,7 +1842,7 @@ struct v4l2_ext_control { · 1841 unmodified lines | ||
| 1842 | 1842 | struct v4l2_ctrl_hdr10_cll_info __user *p_hdr10_cll_info; |
| 1843 | 1843 | struct v4l2_ctrl_hdr10_mastering_display __user *p_hdr10_mastering_display; |
| 1844 | 1844 | void __user *ptr; |
| 1845 | − }; | |
| 1845 | + } __attribute__ ((packed)); | |
| 1846 | 1846 | } __attribute__ ((packed)); |
| 1847 | 1847 | |
| 1848 | 1848 | struct v4l2_ext_controls { |