Fix sparse warning: drivers/platform/chrome/cros_ec_debugfs.c:256:30: warning: symbol 'cros_ec_console_log_fops' was not declared. Should it be static? drivers/platform/chrome/cros_ec_debugfs.c:265:30: warning: symbol 'cros_ec_pdinfo_fops' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lightbar.c:550:24: warning: symbol 'cros_ec_lightbar_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_sysfs.c:338:24: warning: symbol 'cros_ec_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_vbc.c:104:24: warning: symbol 'cros_ec_vbc_attr_group' was not declared. Should it be static? drivers/platform/chrome/cros_ec_lpc.c:408:25: warning: symbol 'cros_ec_lpc_pm_ops' was not declared. Should it be static?
Unified · Split
| @@ -241,7 +241,7 @@ static ssize_t cros_ec_pdinfo_read(struct file *file, · 240 unmodified lines | ||
| 241 | 241 | read_buf, p - read_buf); |
| 242 | 242 | } |
| 243 | 243 | |
| 244 | −const struct file_operations cros_ec_console_log_fops = { | |
| 244 | +static const struct file_operations cros_ec_console_log_fops = { | |
| 245 | 245 | .owner = THIS_MODULE, |
| 246 | 246 | .open = cros_ec_console_log_open, |
| 247 | 247 | .read = cros_ec_console_log_read, |
| @@ -250,7 +250,7 @@ const struct file_operations cros_ec_console_log_fops = { · 2 unmodified lines | ||
| 250 | 250 | .release = cros_ec_console_log_release, |
| 251 | 251 | }; |
| 252 | 252 | |
| 253 | −const struct file_operations cros_ec_pdinfo_fops = { | |
| 253 | +static const struct file_operations cros_ec_pdinfo_fops = { | |
| 254 | 254 | .owner = THIS_MODULE, |
| 255 | 255 | .open = simple_open, |
| 256 | 256 | .read = cros_ec_pdinfo_read, |
| @@ -547,7 +547,7 @@ static struct attribute *__lb_cmds_attrs[] = { · 546 unmodified lines | ||
| 547 | 547 | NULL, |
| 548 | 548 | }; |
| 549 | 549 | |
| 550 | −struct attribute_group cros_ec_lightbar_attr_group = { | |
| 550 | +static struct attribute_group cros_ec_lightbar_attr_group = { | |
| 551 | 551 | .name = "lightbar", |
| 552 | 552 | .attrs = __lb_cmds_attrs, |
| 553 | 553 | }; |
| @@ -405,7 +405,7 @@ static int cros_ec_lpc_resume(struct device *dev) · 404 unmodified lines | ||
| 405 | 405 | } |
| 406 | 406 | #endif |
| 407 | 407 | |
| 408 | −const struct dev_pm_ops cros_ec_lpc_pm_ops = { | |
| 408 | +static const struct dev_pm_ops cros_ec_lpc_pm_ops = { | |
| 409 | 409 | SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume) |
| 410 | 410 | }; |
| 411 | 411 | |
| @@ -335,7 +335,7 @@ static umode_t cros_ec_ctrl_visible(struct kobject *kobj, · 334 unmodified lines | ||
| 335 | 335 | return a->mode; |
| 336 | 336 | } |
| 337 | 337 | |
| 338 | −struct attribute_group cros_ec_attr_group = { | |
| 338 | +static struct attribute_group cros_ec_attr_group = { | |
| 339 | 339 | .attrs = __ec_attrs, |
| 340 | 340 | .is_visible = cros_ec_ctrl_visible, |
| 341 | 341 | }; |
| @@ -101,7 +101,7 @@ static struct bin_attribute *cros_ec_vbc_bin_attrs[] = { · 100 unmodified lines | ||
| 101 | 101 | NULL |
| 102 | 102 | }; |
| 103 | 103 | |
| 104 | −struct attribute_group cros_ec_vbc_attr_group = { | |
| 104 | +static struct attribute_group cros_ec_vbc_attr_group = { | |
| 105 | 105 | .name = "vbc", |
| 106 | 106 | .bin_attrs = cros_ec_vbc_bin_attrs, |
| 107 | 107 | }; |