History

tracing: Add BUILD_BUG() to make sure stacktrace fits in strings

The max string length for a histogram variable is 256 bytes. The max depth of a stacktrace is 16. With 8byte words, that's 16 * 8 = 128. Which can easily fit in the string variable. The histogram stacktrace is being stored in the string value (with the given max length), with the assumption it will fit. To make sure that this is always the case (in the case that the stack trace depth increases), add a BUILD_BUG_ON() to test this. Link: https://lore.kernel.org/linux-trace-kernel/20230214002418.0103b9e765d3e5c374d2aa7d@kernel.org/

Steven Rostedt (Google) committed 3 years ago

Commit 8261ef21 parent fc1a9dc1 file · +3 −0Browse files

Unified · Split

kernel/trace/trace_events_hist.c+3−0
@@ -3119,6 +3119,9 @@ static inline void __update_field_vars(struct tracing_map_elt *elt, · 3118 unmodified lines
3119 unsigned int i, j, var_idx;3119 unsigned int i, j, var_idx;
3120 u64 var_val;3120 u64 var_val;
3121 3121
3122 /* Make sure stacktrace can fit in the string variable length */
3123 BUILD_BUG_ON((HIST_STACKTRACE_DEPTH + 1) * sizeof(long) >= STR_VAR_LEN_MAX);
3124
3122 for (i = 0, j = field_var_str_start; i < n_field_vars; i++) {3125 for (i = 0, j = field_var_str_start; i < n_field_vars; i++) {
3123 struct field_var *field_var = field_vars[i];3126 struct field_var *field_var = field_vars[i];
3124 struct hist_field *var = field_var->var;3127 struct hist_field *var = field_var->var;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t