lib/ts_fsm.c: replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Gustavo A. R. Silva committed 6 years ago

Commit 842ae1f1 parent c6e2ac31 file · +1 −1Browse files

Showing the changes to lib (1 of 1 file). Show all

Unified · Split

lib/ts_fsm.c+1−1

@@ -32,7 +32,7 @@ · 31 unmodified lines
32	32	struct ts_fsm
33	33	{
34	34	unsigned int ntokens;
35		− struct ts_fsm_token tokens[0];
	35	+ struct ts_fsm_token tokens[];
36	36	};
37	37
38	38	/* other values derived from ctype.h */