History

kbuild: error out if $(INSTALL_MOD_PATH) contains % or :

If the directory path given to INSTALL_MOD_PATH contains % or :, the module_install fails. % is used in pattern rules, and : as the separator of dependencies. Bail out with a clearer error message.

Masahiro Yamada committed 4 years ago

Commit 84850db1 parent 9a68fd71 file · +3 −0Browse files

Unified · Split

scripts/Makefile.modinst+3−0
@@ -18,6 +18,9 @@ INSTALL_MOD_DIR ?= extra · 17 unmodified lines
1818 dst := $(MODLIB)/$(INSTALL_MOD_DIR)
1919 endif
2020
21+$(foreach x, % :, $(if $(findstring $x, $(dst)), \
22+ $(error module installation path cannot contain '$x')))
23+
2124 suffix-y :=
2225 suffix-$(CONFIG_MODULE_COMPRESS_GZIP) := .gz
2326 suffix-$(CONFIG_MODULE_COMPRESS_XZ) := .xz

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t