History

ASoC: qcom: lpass-sc7180: Delete redundant error log from _resume()

sc7180_lpass_dev_resume() logs an error if clk_bulk_prepare_enable() fails. The clock framework already generates error logs if anything goes wrong, so the logging in _resume() is redundant, drop it.

Matthias Kaehlcke committed 3 years ago

Commit 863b9171 parent a3a96e91 file · +1 −7Browse files

Unified · Split

sound/soc/qcom/lpass-sc7180.c+1−7
@@ -165,15 +165,9 @@ static int sc7180_lpass_exit(struct platform_device *pdev) · 164 unmodified lines
165 165
166static int sc7180_lpass_dev_resume(struct device *dev)166static int sc7180_lpass_dev_resume(struct device *dev)
167{167{
168 int ret = 0;
169 struct lpass_data *drvdata = dev_get_drvdata(dev);168 struct lpass_data *drvdata = dev_get_drvdata(dev);
170 169
171 ret = clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);170 return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
172 if (ret) {
173 dev_err(dev, "sc7180 clk prepare and enable failed\n");
174 return ret;
175 }
176 return ret;
177}171}
178 172
179static int sc7180_lpass_dev_suspend(struct device *dev)173static int sc7180_lpass_dev_suspend(struct device *dev)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t