History

function-graph: Fix seqfile memory leak

Every time we cat set_graph_function, we leak memory allocated by seq_open().

Li Zefan committed 17 years ago

Commit 87827111 parent d8cc1ab1 file · +12 −3Browse files

Showing the changes to kernel/trace (1 of 1 file). Show all

Unified · Split

kernel/trace/ftrace.c+12−3
@@ -2595,6 +2595,14 @@ ftrace_graph_open(struct inode *inode, struct file *file) · 2594 unmodified lines
2595 return ret;2595 return ret;
2596}2596}
2597 2597
2598static int
2599ftrace_graph_release(struct inode *inode, struct file *file)
2600{
2601 if (file->f_mode & FMODE_READ)
2602 seq_release(inode, file);
2603 return 0;
2604}
2605
2598static int2606static int
2599ftrace_set_func(unsigned long *array, int *idx, char *buffer)2607ftrace_set_func(unsigned long *array, int *idx, char *buffer)
2600{2608{
@@ -2724,9 +2732,10 @@ ftrace_graph_write(struct file *file, const char __user *ubuf, · 123 unmodified lines
2724}2732}
2725 2733
2726static const struct file_operations ftrace_graph_fops = {2734static const struct file_operations ftrace_graph_fops = {
2727 .open = ftrace_graph_open,2735 .open = ftrace_graph_open,
2728 .read = seq_read,2736 .read = seq_read,
2729 .write = ftrace_graph_write,2737 .write = ftrace_graph_write,
2738 .release = ftrace_graph_release,
2730};2739};
2731#endif /* CONFIG_FUNCTION_GRAPH_TRACER */2740#endif /* CONFIG_FUNCTION_GRAPH_TRACER */
2732 2741