Every time we cat set_graph_function, we leak memory allocated by seq_open().
Showing the changes to kernel/trace (1 of 1 file). Show all
Unified · Split
| @@ -2595,6 +2595,14 @@ ftrace_graph_open(struct inode *inode, struct file *file) · 2594 unmodified lines | ||
| 2595 | 2595 | return ret; |
| 2596 | 2596 | } |
| 2597 | 2597 | |
| 2598 | +static int | |
| 2599 | +ftrace_graph_release(struct inode *inode, struct file *file) | |
| 2600 | +{ | |
| 2601 | + if (file->f_mode & FMODE_READ) | |
| 2602 | + seq_release(inode, file); | |
| 2603 | + return 0; | |
| 2604 | +} | |
| 2605 | + | |
| 2598 | 2606 | static int |
| 2599 | 2607 | ftrace_set_func(unsigned long *array, int *idx, char *buffer) |
| 2600 | 2608 | { |
| @@ -2724,9 +2732,10 @@ ftrace_graph_write(struct file *file, const char __user *ubuf, · 123 unmodified lines | ||
| 2724 | 2732 | } |
| 2725 | 2733 | |
| 2726 | 2734 | static const struct file_operations ftrace_graph_fops = { |
| 2727 | − .open = ftrace_graph_open, | |
| 2728 | − .read = seq_read, | |
| 2729 | − .write = ftrace_graph_write, | |
| 2735 | + .open = ftrace_graph_open, | |
| 2736 | + .read = seq_read, | |
| 2737 | + .write = ftrace_graph_write, | |
| 2738 | + .release = ftrace_graph_release, | |
| 2730 | 2739 | }; |
| 2731 | 2740 | #endif /* CONFIG_FUNCTION_GRAPH_TRACER */ |
| 2732 | 2741 | |