History

modules: Ensure natural alignment for .altinstructions and __bug_table sections

In the kernel image vmlinux.lds.S linker scripts the .altinstructions and __bug_table sections are 4- or 8-byte aligned because they hold 32- and/or 64-bit values. Most architectures use altinstructions and BUG() or WARN() in modules as well, but in the module linker script (module.lds.S) those sections are currently missing. As consequence the linker will store their content byte-aligned by default, which then can lead to unnecessary unaligned memory accesses by the CPU when those tables are processed at runtime. Usually unaligned memory accesses are unnoticed, because either the hardware (as on x86 CPUs) or in-kernel exception handlers (e.g. on parisc or sparc) emulate and fix them up at runtime. Nevertheless, such unaligned accesses introduce a performance penalty and can even crash the kernel if there is a bug in the unalignment exception handlers (which happened once to me on the parisc architecture and which is why I noticed that issue at all). This patch fixes a non-critical issue and might be backported at any time. It's trivial and shouldn't introduce any regression because it simply tells the linker to use a different (8-byte alignment) for those sections by default.

Helge Deller committed 4 years ago

Commit 87c482b1 parent 07ade451 file · +2 −0Browse files

Showing the changes to scripts (1 of 1 file). Show all

Unified · Split

scripts/module.lds.S+2−0
@@ -27,6 +27,8 @@ SECTIONS { · 26 unmodified lines
2727 .ctors 0 : ALIGN(8) { *(SORT(.ctors.*)) *(.ctors) }
2828 .init_array 0 : ALIGN(8) { *(SORT(.init_array.*)) *(.init_array) }
2929
30+ .altinstructions 0 : ALIGN(8) { KEEP(*(.altinstructions)) }
31+ __bug_table 0 : ALIGN(8) { KEEP(*(__bug_table)) }
3032 __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) }
3133
3234 __patchable_function_entries : { *(__patchable_function_entries) }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t