The genksyms source was integrated into the kernel tree in 2003. I do not expect anybody still using the external /sbin/genksyms. Kbuild does not need to provide the ability to override GENKSYMS. Let's remove the GENKSYMS variable, and use the hardcoded path. Since it occurred in the pre-git era, I attached the commit message in case somebody is interested in the historical background. | Author: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de> | Date: Wed Feb 19 04:17:28 2003 -0600 | | kbuild: [PATCH] put genksyms in scripts dir | | This puts genksyms into scripts/genksyms/. | | genksyms used to be maintained externally, though the only possible user | was the kernel build. Moving it into the kernel sources makes it easier to | keep it uptodate, like for example updating it to generate linker scripts | directly instead of postprocessing the generated header file fragments | with sed, as we do currently. | | Also, genksyms does not handle __typeof__, which needs to be fixed since | some of the exported symbol in the kernel are defined using __typeof__. | | (Rusty Russell/me)
Showing the changes to scripts (1 of 2 files). Show all
Unified · Split
| @@ -120,7 +120,7 @@ $(obj)/%.i: $(src)/%.c FORCE · 119 unmodified lines | |||
| 120 | # These mirror gensymtypes_S and co below, keep them in synch. | 120 | # These mirror gensymtypes_S and co below, keep them in synch. |
| 121 | cmd_gensymtypes_c = \ | 121 | cmd_gensymtypes_c = \ |
| 122 | $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ | 122 | $(CPP) -D__GENKSYMS__ $(c_flags) $< | \ |
| 123 | $(GENKSYMS) $(if $(1), -T $(2)) \ | 123 | scripts/genksyms/genksyms $(if $(1), -T $(2)) \ |
| 124 | $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ | 124 | $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ |
| 125 | $(if $(KBUILD_PRESERVE),-p) \ | 125 | $(if $(KBUILD_PRESERVE),-p) \ |
| 126 | -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) | 126 | -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) |
| @@ -320,7 +320,7 @@ cmd_gensymtypes_S = \ · 193 unmodified lines | |||
| 320 | grep "\<___EXPORT_SYMBOL\>" | \ | 320 | grep "\<___EXPORT_SYMBOL\>" | \ |
| 321 | sed 's/.*___EXPORT_SYMBOL[[:space:]]*\([a-zA-Z0-9_]*\)[[:space:]]*,.*/EXPORT_SYMBOL(\1);/' ; } | \ | 321 | sed 's/.*___EXPORT_SYMBOL[[:space:]]*\([a-zA-Z0-9_]*\)[[:space:]]*,.*/EXPORT_SYMBOL(\1);/' ; } | \ |
| 322 | $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | \ | 322 | $(CPP) -D__GENKSYMS__ $(c_flags) -xc - | \ |
| 323 | $(GENKSYMS) $(if $(1), -T $(2)) \ | 323 | scripts/genksyms/genksyms $(if $(1), -T $(2)) \ |
| 324 | $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ | 324 | $(patsubst y,-R,$(CONFIG_MODULE_REL_CRCS)) \ |
| 325 | $(if $(KBUILD_PRESERVE),-p) \ | 325 | $(if $(KBUILD_PRESERVE),-p) \ |
| 326 | -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) | 326 | -r $(firstword $(wildcard $(2:.symtypes=.symref) /dev/null)) |