The variable "head" is allocated and initialized as a list before allocating the first "item" for the list. If the allocation of "item" fails, it frees "head" and then jumps to the label "free_now" which will process head and free it. This will cause a UAF of "head", and it doesn't need to free it before jumping to the "free_now" label as that code will free it.
Unified · Split
| @@ -1437,10 +1437,8 @@ static void filter_free_subsystem_filters(struct trace_subsystem_dir *dir, · 1436 unmodified lines | ||
| 1437 | 1437 | INIT_LIST_HEAD(&head->list); |
| 1438 | 1438 | |
| 1439 | 1439 | item = kmalloc(sizeof(*item), GFP_KERNEL); |
| 1440 | − if (!item) { | |
| 1441 | − kfree(head); | |
| 1440 | + if (!item) | |
| 1442 | 1441 | goto free_now; |
| 1443 | − } | |
| 1444 | 1442 | |
| 1445 | 1443 | item->filter = filter; |
| 1446 | 1444 | list_add_tail(&item->list, &head->list); |