History

kconfig: let 'shell' return enough output for deep path names

The 'shell' built-in only returns the first 256 bytes of the command's output. In some cases, 'shell' is used to return a path; by bumping up the buffer size to 4096 this lets us capture up to PATH_MAX. The specific case where I ran into this was due to commit 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test"). After this change, we now use `$(shell,$(CC) -print-file-name=plugin)` to return a path; if the gcc path is particularly long, then the path ends up truncated at the 256 byte mark, which makes the HAVE_GCC_PLUGINS depends test always fail.

Brenda Streiff committed 4 years ago

Commit 8a4c5b21 parent dfd42fa1 file · +1 −1Browse files

Unified · Split

scripts/kconfig/preprocess.c+1−1
@@ -141,7 +141,7 @@ static char *do_lineno(int argc, char *argv[]) · 140 unmodified lines
141141 static char *do_shell(int argc, char *argv[])
142142 {
143143 FILE *p;
144− char buf[256];
144+ char buf[4096];
145145 char *cmd;
146146 size_t nread;
147147 int i;