History

tty: handle the case where we cannot restore a line discipline

Historically the N_TTY driver could never fail but this has become broken over time. Rather than trying to rewrite half the ldisc layer to fix the breakage introduce a second level of fallback with an N_NULL ldisc which cannot fail, and thus restore the guarantees required by the ldisc layer. We still try and fail to N_TTY first. It's much more useful to find yourself back in your old ldisc (first attempt) or in N_TTY (second attempt), and while I'm not aware of any code out there that makes those assumptions it's good to drive(r) defensively.

Alan Cox committed 9 years ago

Commit 8a8dabf1 parent 47f58e34 files · +113 −15Browse files

Showing the changes to include/uapi/linux (1 of 4 files). Show all

Unified · Split

include/uapi/linux/tty.h+1−0
@@ -36,5 +36,6 @@ · 35 unmodified lines
3636 #define N_TRACEROUTER 24 /* Trace data routing for MIPI P1149.7 */
3737 #define N_NCI 25 /* NFC NCI UART */
3838 #define N_SPEAKUP 26 /* Speakup communication with synths */
39+#define N_NULL 27 /* Null ldisc used for error handling */
3940
4041 #endif /* _UAPI_LINUX_TTY_H */