We realized that the power usage field is never filled and when it is filled for tegra, the power_specified flag is not set causing all of these values to be reset when the driver is initialized with set_power_state(). However, the power_specified flag can be simply removed under the assumption that the states are always backward sorted, which is the case with the current code. This change allows the menu governor select function and the cpuidle_play_dead() to be simplified. Moreover, the set_power_states() function can removed as it does not make sense any more. Drop the power_specified flag from struct cpuidle_driver and make the related changes as described above. As a consequence, this also fixes the bug where on the dynamic C-states system, the power fields are not initialized. [rjw: Changelog] References: https://bugzilla.kernel.org/show_bug.cgi?id=42870 References: https://bugzilla.kernel.org/show_bug.cgi?id=43349 References: https://lkml.org/lkml/2012/10/16/518 Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Showing the changes to include/linux (1 of 4 files). Show all
Unified · Split
| @@ -126,9 +126,9 @@ struct cpuidle_driver { · 125 unmodified lines | ||
| 126 | 126 | struct module *owner; |
| 127 | 127 | int refcnt; |
| 128 | 128 | |
| 129 | − unsigned int power_specified:1; | |
| 130 | 129 | /* set to 1 to use the core cpuidle time keeping (for all states). */ |
| 131 | 130 | unsigned int en_core_tk_irqen:1; |
| 131 | + /* states array must be ordered in decreasing power consumption */ | |
| 132 | 132 | struct cpuidle_state states[CPUIDLE_STATE_MAX]; |
| 133 | 133 | int state_count; |
| 134 | 134 | int safe_state_index; |