History

Revert "nl80211: add src and dst addr attributes for control port tx/rx"

This reverts commit 8c3ed7aa2b9ef666195b789e9b02e28383243fa8. As Jouni points out, there's really no need for this, since the RSN pre-authentication frames are normal data frames, not port control frames (locally). We can still revert this now since it hasn't actually gone beyond -next.

Johannes Berg committed 6 years ago

Commit 8d74a621 parent 8079e4f7 files · +21 −57Browse files

Showing the changes to include/uapi/linux (1 of 7 files). Show all

Unified · Split

include/uapi/linux/nl80211.h+1−15
@@ -1039,14 +1039,11 @@ · 1038 unmodified lines
10391039 * a control port frame and as a notification that a control port frame
10401040 * has been received. %NL80211_ATTR_FRAME is used to specify the
10411041 * frame contents. The frame is the raw EAPoL data, without ethernet or
1042− * 802.11 headers. An optional %NL80211_ATTR_SRC_MAC can be used to send
1043− * pre-auth frames to STAs on behalf of other APs.
1042+ * 802.11 headers.
10441043 * When used as an event indication %NL80211_ATTR_CONTROL_PORT_ETHERTYPE,
10451044 * %NL80211_ATTR_CONTROL_PORT_NO_ENCRYPT and %NL80211_ATTR_MAC are added
10461045 * indicating the protocol type of the received frame; whether the frame
10471046 * was received unencrypted and the MAC address of the peer respectively.
1048− * %NL80211_ATTR_DST_MAC can be used to forward pre-auth frames in
1049− * userspace while using AP mode.
10501047 *
10511048 * @NL80211_CMD_RELOAD_REGDB: Request that the regdb firmware file is reloaded.
10521049 *
@@ -2412,9 +2409,6 @@ enum nl80211_commands { · 1359 unmodified lines
24122409 * %NL80211_ATTR_AKM_SUITES are default capabilities if AKM suites not
24132410 * advertised for a specific interface type.
24142411 *
2415− * @NL80211_ATTR_SRC_MAC: MAC address used in control port over nl80211 transmit
2416− * @NL80211_ATTR_DST_MAC: MAC address used in control port over nl80211 receive
2417− *
24182412 * @NUM_NL80211_ATTR: total number of nl80211_attrs available
24192413 * @NL80211_ATTR_MAX: highest attribute number currently defined
24202414 * @__NL80211_ATTR_AFTER_LAST: internal use
@@ -2883,9 +2877,6 @@ enum nl80211_attrs { · 462 unmodified lines
28832877
28842878 NL80211_ATTR_IFTYPE_AKM_SUITES,
28852879
2886− NL80211_ATTR_SRC_MAC,
2887− NL80211_ATTR_DST_MAC,
2888−
28892880 /* add attributes here, update the policy in nl80211.c */
28902881
28912882 __NL80211_ATTR_AFTER_LAST,
@@ -5548,10 +5539,6 @@ enum nl80211_feature_flags { · 2656 unmodified lines
55485539 * feature, which prevents bufferbloat by using the expected transmission
55495540 * time to limit the amount of data buffered in the hardware.
55505541 *
5551− * @NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS: The driver
5552− * can use src and dst MAC addresses with control port over nl80211 rx
5553− * and tx operations.
5554− *
55555542 * @NUM_NL80211_EXT_FEATURES: number of extended features.
55565543 * @MAX_NL80211_EXT_FEATURES: highest extended feature index.
55575544 */
@@ -5599,7 +5586,6 @@ enum nl80211_ext_feature_index { · 41 unmodified lines
55995586 NL80211_EXT_FEATURE_SAE_OFFLOAD,
56005587 NL80211_EXT_FEATURE_VLAN_OFFLOAD,
56015588 NL80211_EXT_FEATURE_AQL,
5602− NL80211_EXT_FEATURE_CONTROL_PORT_OVER_NL80211_MAC_ADDRS,
56035589
56045590 /* add new features before the definition below */
56055591 NUM_NL80211_EXT_FEATURES,