History

tcp/dccp: fix possible race __inet_lookup_established()

Michal Kubecek and Firo Yang did a very nice analysis of crashes happening in __inet_lookup_established(). Since a TCP socket can go from TCP_ESTABLISH to TCP_LISTEN (via a close()/socket()/listen() cycle) without a RCU grace period, I should not have changed listeners linkage in their hash table. They must use the nulls protocol (Documentation/RCU/rculist_nulls.txt), so that a lookup can detect a socket in a hash list was moved in another one. Since we added code in commit d296ba60d8e2 ("soreuseport: Resolve merge conflict for v4/v6 ordering fix"), we have to add hlist_nulls_add_tail_rcu() helper.

Eric Dumazet committed 6 years ago

Commit 8dbd76e1 parent 8f9cc1e6 files · +65 −15Browse files

Showing the changes to include/net (2 of 6 files). Show all

Unified · Split

2 files
  1. include/net/inet_hashtables.h +9 −3
  2. include/net/sock.h +5 −0
include/net/inet_hashtables.h+9−3
@@ -103,13 +103,19 @@ struct inet_bind_hashbucket { · 102 unmodified lines
103103 struct hlist_head chain;
104104 };
105105
106−/*
107− * Sockets can be hashed in established or listening table
106+/* Sockets can be hashed in established or listening table.
107+ * We must use different 'nulls' end-of-chain value for all hash buckets :
108+ * A socket might transition from ESTABLISH to LISTEN state without
109+ * RCU grace period. A lookup in ehash table needs to handle this case.
108110 */
111+#define LISTENING_NULLS_BASE (1U << 29)
109112 struct inet_listen_hashbucket {
110113 spinlock_t lock;
111114 unsigned int count;
112− struct hlist_head head;
115+ union {
116+ struct hlist_head head;
117+ struct hlist_nulls_head nulls_head;
118+ };
113119 };
114120
115121 /* This is for listening sockets, thus all sockets which possess wildcards. */
include/net/sock.h+5−0
@@ -722,6 +722,11 @@ static inline void __sk_nulls_add_node_rcu(struct sock *sk, struct hlist_nulls_h · 721 unmodified lines
722722 hlist_nulls_add_head_rcu(&sk->sk_nulls_node, list);
723723 }
724724
725+static inline void __sk_nulls_add_node_tail_rcu(struct sock *sk, struct hlist_nulls_head *list)
726+{
727+ hlist_nulls_add_tail_rcu(&sk->sk_nulls_node, list);
728+}
729+
725730 static inline void sk_nulls_add_node_rcu(struct sock *sk, struct hlist_nulls_head *list)
726731 {
727732 sock_hold(sk);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t